-
Notifications
You must be signed in to change notification settings - Fork 24
Tournament Data Export + Tab Card Refactor #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoeyRubas
wants to merge
27
commits into
MIT-Tab:master
Choose a base branch
from
JoeyRubas:csv-export
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
a4d86c0
Impliment CSV, JSON exports for tab cards. Refactor existing tab card…
JoeyRubas 45569f8
various misc tweaks
JoeyRubas bd9911c
censor team names
JoeyRubas 844a428
some changes to address the PR comments
JoeyRubas 19dd796
formatting for linter
JoeyRubas 47d3b7b
down to 1 linter error
JoeyRubas acc7369
fix last lint error
JoeyRubas fe2fc5d
fixed linting errors, added dedicated page for exports, merged export…
JoeyRubas e4d9729
final final linting errors fixed (hopefully)
JoeyRubas 097040d
add ids to CSV
JoeyRubas bc31a65
fix header order
JoeyRubas 0cc33a7
Merge remote-tracking branch 'origin/master' into csv-export
JoeyRubas 6ed827b
bugfix
JoeyRubas 8f9e6fe
Merge remote-tracking branch 'origin/master' into csv-export
JoeyRubas e21029e
url -> path
JoeyRubas f771277
Merge remote-tracking branch 'origin/master' into csv-export
JoeyRubas 6a11683
lint nit
JoeyRubas df5c0d5
Merge branch 'master' into csv-export
BenMusch 18d98d9
Merge remote-tracking branch 'origin/master' into csv-export
JoeyRubas c12c9dc
nullsave
JoeyRubas 66b4b81
add export to s3
JoeyRubas 1db7e15
Merge branch 'master' into csv-export
JoeyRubas e925af8
cleanup
JoeyRubas e7c7994
Update mittab/urls.py
JoeyRubas c766387
Update mittab/templates/common/_form.html
JoeyRubas bd3307f
Update mittab/libs/data_export/tab_card.py
JoeyRubas 06ba62e
final cleanup
JoeyRubas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing blank line before class definition. According to PEP 8, there should be two blank lines before top-level class definitions. Add a blank line before
class ExportFormatForm.