[pull] main from llvm:main - #1675
Merged
Merged
Conversation
Similar to #209414 but for AnalysisPassConcept. This avoids vtables for every analysis pass.
Rewrite SemaHIP cc1 test RUN lines to the new subarch triple form, dropping the redundant -target-cpu. Co-authored-by: Claude (Opus 4.8) <noreply@anthropic.com>
Legacy ThinLTO omits -mllvm options from cache keys, which can cause it to reuse objects built with different code-generation settings. Include these options in cache keys, matching modern ThinLTO behavior.
In #180244 (8e76c3f), handling of Instruction::Sub in createSCEV declared PtrLHS and PtrRHS as uninitialized local variables. When only one side matched m_PtrToInt, the other variable remained uninitialized. Passing it by value to GetOp copied uninitialized shadow bytes, causing MemorySanitizer to report use-of-uninitialized-value. Initialize PtrLHS and PtrRHS to nullptr upon declaration. Assisted-by: Gemini
…nters on Windows (#211355) Fixes #209787 It was an oversight that the builtin only takes care of the virtual function table pointer but not the virtual base pointer. On Itanium there is one pointer so it wasn't a problem but on windows msvc , this is a problem. And the runtime test in libcxx CI was disabled in llvm 23 because we don't use trunk clang in our libcxx CI in general. and after we flipped to llvm 24, the test started to fail on downstream (chromium) where they use trunk clang with trunk libc++ on Windows. We do have FileCheck test in clang test which covers this virtual case. However, the target triple in the FileCheck under test were `x86_64-linux-gnu` and `x86_64-windows-gnu` , which does not cover the Windows msvc ABI. I updated the test to test `x86_64-pc-windows-msvc` in this PR to cover that ABI.
The original PR was reverted in #206816 due to a test failure on lldb-aarch64-ubuntu. Since I couldn't reproduce the failure, I decided to split the PR into smaller chunks. This is part 1/4 (the final state is on https://github.com/Nerixyz/llvm-project/tree/refactor/common-abi-runtime-take2-4-of-4). It moves `GetVTableInfo` and `TypeHasVTable` from the Itanium ABI runtime to the C++ language runtime. Eventually, this will be used to select the ABI runtime that's able to handle a vtable. For now, we always ask and use Itanium.
Similar to the existing ptrtoint fold; this is valid, because icmp only compares address bits. This addresses optimization regressions when generating ptrtoaddr for pointer subtractions.
) Extend the widenConsecutiveMemOps sub-pass to widen masked/predicated unit-stride consecutive accesses VPlan-natively. This requires exposing an instruction-independent isLegalMaskedLoadOrStore in VPSelectionContext, as well as adding it to VPCostContext. Some of the members will probably be useful for other changes as well. PR: #211315
The original removal of `BB->Default` has been handled by `createUnreachableSwitchDefault`. When `OtherDest` is also unreachable, the edge should be removed. This issue cannot be reproduced via `-simplifycfg-require-and-preserve-domtree=1`. I just found it by checking DT in `requestResimplify`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )