[pull] main from llvm:main - #1680
Merged
Merged
Conversation
…ICmp` (#212035) Previously we relied on `createUnreachableSwitchDefault` to remove incoming edges in phi nodes and update DT. However, it also creates a new unreachable BB and updates the default destination of the switch instruction, which is about to be replaced by a branch instruction. This patch inlines the function and removes logic about the new BB, to make sure the DT is updated correctly. This issue cannot be reproduced via -simplifycfg-require-and-preserve-domtree=1. I just found it by checking DT in requestResimplify (will be added after fixing all existing issues). The following test covers this case: https://github.com/llvm/llvm-project/blob/5bc304c65494702d9d4928ff6cb369e6e6496e53/llvm/test/Transforms/SimplifyCFG/switch-range-to-icmp.ll#L38-L73
…ute (#211795) IntrusiveRefCntPtr has non-trivial ctor/dtor, thus unused variables wouldn't trigger a warning by default. However, they should. https://clang.llvm.org/docs/AttributeReference.html#warn-unused Let's mark the class with this attribute get warned about them. This would have helped catching #211518 and #211517. Supersedes #211647. Some tests had to be uplifted because some bots used `-Werror` for those tests.
This PR fixes _Atomic crashes for Z3 symbolic execution by passing the types through getAtomicUnqualifiedType and getCanonicalType and skip casting in fromCast if `FromTy == ToTy && FromBitWidth == ToBitWidth`. Assisted-by: Codex
The oldest library we support is from LLVM 12, so we can remove any XFAILs for libraries built before that.
…210895) This PR generally updates `cpp::string` to avoid incidental allocations. Specifically, it: - Updates `opreator=(string_view)` to avoid allocating a temporary string: https://github.com/llvm/llvm-project/blob/67ebc4b221c3e94028b33004cd5cd08deee95048/libc/src/__support/CPP/string.h#L106-L108 - Changes `operator+=(const string&)` to accept a `string_view` so that strings may be appended without allocation. - Makes the `string(string_view)` constructor explicit. Before, there were non-obvious allocations because of the implicit conversion. As a side effect, this PR has to more carefully handle self-assignment and self-append. This PR updates append and assignment to avoid calling `realloc` during append / assignment, as this may invalidate input pointers held by `string_view` if they point to data held by the string. This also fixes self-assignment, which previously didn't work, eg `cpp::string s = "abc"; s = s;` would zero out `s`.
…__pstl::__parallel_find() (#209291) This PR adds a parallel version of `std::mismatch` as one of the backend operations. It also provides an implementation based on `__pstl::__parallel_find()` which does the heavy lifting. `libdispatch` and `std_thread` backends expose this implementation under their backend tags, while the `serial` backend redirects the calls to the serial `std::mismatch`. 4 flavours of the function are exposed: 3-legged, 3-legged with predicate, 4-legged, 4-legged with predicate. 3-legged flavours are implemented in the `default` (`composition`) backend by redirecting the call to the 4-legged flavours. Included tests check that: - Semantics of the iterator-only functions is correct. - Semantics of the predicated functions is correct. - Custom types are supported by the implementation. - The functions correctly SFINAE out when the first argument is not an execution policy. - The `nodiscard` policy is followed. - The `noexcept` policy is followed. - `static_assert` verifies iterators' categories. Part of #99938.
CompoundAssignOperator (e.g. `+=`, `-=`, `<<=`) is a distinct StmtClass deriving from BinaryOperator, but it was not handled in the CFGBuilder dispatch switches. As a result it fell through to the generic default path (VisitChildren over reverse_children), which emits the LHS before the RHS in the CFG. Per C++17 [expr.ass]/1, all assignment operators - simple and compound - sequence the right operand before the left operand. Route CompoundAssignOperator through VisitBinaryOperator (and VisitBinaryOperatorForTemporaries), whose existing isAssignmentOp() branch already emits the RHS before the LHS, matching simple assignment. This mirrors the class of evaluation-order defect fixed for lambda captures in f3b3187. rdar://183253943 Assisted-By: claude
The `fstream` member functions are all really short, so inlining them removes quite a bit of boiler plate code.
…structed from unsigned durations (#209686) **_Implementation details_**: - Use `is_unsigned_v` instead of `numeric_limits<Rep>::is_signed`, which is used by `chrono::abs`. `numeric_limits<Rep>::is_signed` may return false when a custom `Rep` does not specialize `numeric_limits`. Relying on it to detect the unsigned case could therefore be unreliable for such a type. `is_unsigned_v` instead gives a compile-time path for built-in unsigned types, while the sign check keeps signed types correct. - The constructor calls `__abs_d` four times because each member is initialized separately. This should not affect runtime performance because the compiler should inline `__abs_d` and eliminate the repeated calculations. We could use another helper function or helper class to explicitly compute the absolute duration only once. However, this would add extra glue code, and the added complexity is not worthwhile I think. --------- Co-authored-by: A. Jiang <de34@live.cn>
Add value-preserving folds mirroring LLVM's InstructionSimplify for the integer division and remainder ops: ``` divui/divsi/ceildivui/ceildivsi/floordivsi(0, x) -> 0 divui/divsi/ceildivui/ceildivsi/floordivsi(x, x) -> 1 remui/remsi(0, x) -> 0 remui/remsi(x, x) -> 0 ``` The self and zero-dividend cases are valid refinements because division or remainder by zero is undefined behaviour; no overflow flags are required. The folds return a scalar or splat constant and bail out on shaped types with a dynamic shape. Folding `x / 0` and `x % 0` to poison is left as a TODO: it would make the arith dialect depend on the ub dialect to materialize `ub.poison`. LLVM performs the same simplifications: https://godbolt.org/z/dzTjYjs4e Verified with Alive2: | Fold | udiv | sdiv | urem | srem | | :--- | :---: | :---: | :---: | :---: | | `x / x -> 1`, `x % x -> 0` | [✓](https://alive2.llvm.org/ce/z/YjZCEA) | [✓](https://alive2.llvm.org/ce/z/BSWQrm) | [✓](https://alive2.llvm.org/ce/z/gx5sRH) | [✓](https://alive2.llvm.org/ce/z/VUYkr4) | | `0 / x -> 0`, `0 % x -> 0` | [✓](https://alive2.llvm.org/ce/z/keqeCZ) | [✓](https://alive2.llvm.org/ce/z/jyf5wm) | [✓](https://alive2.llvm.org/ce/z/fZa6ND) | [✓](https://alive2.llvm.org/ce/z/fo6ss8) | ---- Code generated by Claude Code. Signed-off-by: Víctor Pérez Carrasco <victor.pc.upm@gmail.com>
The migration to UncondBr/CondBr was finished in LLVM 23. BranchInst has no remaining uses in-tree. Let's finish this by removing BranchInst. https://discourse.llvm.org/t/rfc-split-branchinst-into-uncondbr-and-condbr/90022 Deprecated with: #187314
…d directory." (#211294) This reverts commit 611d015. Breaks building, see #197843 (comment)
…#212130) Add more tests for failed decomposition, consolidate them in partial-decomposition.ll.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )