Remove hardcoded server constants and use parsed constants from Server.m2d / constants.xml

Maple2.Database/Model/Mail.cs

@@ -55,7 +55,7 @@ internal class Mail {
 
     [return: NotNullIfNotNull(nameof(other))]
     public static implicit operator Maple2.Model.Game.Mail?(Mail? other) {
-        return other == null ? null : new Maple2.Model.Game.Mail {
+        return other == null ? null : new Maple2.Model.Game.Mail() {
             ReceiverId = other.ReceiverId,
             Id = other.Id,
             SenderId = other.SenderId,

Maple2.Database/Storage/Game/GameStorage.Map.cs

@@ -111,11 +111,11 @@ public IList<PlotCube> LoadCubesForOwner(long ownerId) {
             return Context.TrySaveChanges() ? ToPlotInfo(model) : null;
         }
 
-        public PlotInfo? GetSoonestPlotFromExpire() {
+        public PlotInfo? GetSoonestPlotFromExpire(TimeSpan ugcHomeSaleWaitingTime) {
             IQueryable<UgcMap> maps = Context.UgcMap.Where(map => map.ExpiryTime > DateTimeOffset.MinValue && !map.Indoor);
             foreach (UgcMap map in maps) {
                 if (map.OwnerId == 0) {
-                    map.ExpiryTime = map.ExpiryTime.Add(Constant.UgcHomeSaleWaitingTime);
+                    map.ExpiryTime = map.ExpiryTime.Add(ugcHomeSaleWaitingTime);
                 }
             }
             UgcMap? model = maps.OrderBy(map => map.ExpiryTime).FirstOrDefault();

Maple2.Database/Storage/Metadata/ServerTableMetadataStorage.cs

@@ -29,6 +29,7 @@ public class ServerTableMetadataStorage {
     private readonly Lazy<CombineSpawnTable> combineSpawnTable;
     private readonly Lazy<EnchantOptionTable> enchantOptionTable;
     private readonly Lazy<UnlimitedEnchantOptionTable> unlimitedEnchantOptionTable;
+    private readonly Lazy<ConstantsTable> constantsTable;
 
     public InstanceFieldTable InstanceFieldTable => instanceFieldTable.Value;
     public ScriptConditionTable ScriptConditionTable => scriptConditionTable.Value;
@@ -53,6 +54,7 @@ public class ServerTableMetadataStorage {
     public CombineSpawnTable CombineSpawnTable => combineSpawnTable.Value;
     public EnchantOptionTable EnchantOptionTable => enchantOptionTable.Value;
     public UnlimitedEnchantOptionTable UnlimitedEnchantOptionTable => unlimitedEnchantOptionTable.Value;
+    public ConstantsTable ConstantsTable => constantsTable.Value;
 
     public ServerTableMetadataStorage(MetadataContext context) {
         instanceFieldTable = Retrieve<InstanceFieldTable>(context, ServerTableNames.INSTANCE_FIELD);
@@ -78,6 +80,7 @@ public ServerTableMetadataStorage(MetadataContext context) {
         combineSpawnTable = Retrieve<CombineSpawnTable>(context, ServerTableNames.COMBINE_SPAWN);
         enchantOptionTable = Retrieve<EnchantOptionTable>(context, ServerTableNames.ENCHANT_OPTION);
         unlimitedEnchantOptionTable = Retrieve<UnlimitedEnchantOptionTable>(context, ServerTableNames.UNLIMITED_ENCHANT_OPTION);
+        constantsTable = Retrieve<ConstantsTable>(context, ServerTableNames.CONSTANTS);
     }
 
     public IEnumerable<GameEvent> GetGameEvents() {

Maple2.File.Ingest/Mapper/NpcMapper.cs

@@ -31,13 +31,13 @@ protected override IEnumerable<NpcMetadata> Map() {
                     AniSpeed: data.model.anispeed
                 ),
                 Distance: new NpcMetadataDistance(
-                    Avoid: data.distance.avoid,
-                    Sight: data.distance.sight,
-                    SightHeightUp: data.distance.sightHeightUP,
-                    SightHeightDown: data.distance.sightHeightDown,
-                    LastSightRadius: data.distance.customLastSightRadius == 0 ? Constant.NpcLastSightRadius : data.distance.customLastSightRadius,
-                    LastSightHeightUp: data.distance.customLastSightHeightUp == 0 ? Constant.NpcLastSightHeightUp : data.distance.customLastSightHeightUp,
-                    LastSightHeightDown: data.distance.customLastSightHeightDown == 0 ? Constant.NpcLastSightHeightDown : data.distance.customLastSightHeightDown
+                    data.distance.avoid,
+                    data.distance.sight,
+                    data.distance.sightHeightUP,
+                    data.distance.sightHeightDown,
+                    data.distance.customLastSightRadius,
+                    data.distance.customLastSightHeightUp,
+                    data.distance.customLastSightHeightDown
                 ),
                 Skill: new NpcMetadataSkill(
                     Entries: data.skill.ids.Select((skillId, i) =>

Maple2.File.Ingest/Mapper/ServerTableMapper.cs

@@ -1,10 +1,9 @@
-using System.Globalization;
-using System.Xml;
-using Maple2.Database.Extensions;
+using Maple2.Database.Extensions;
 using Maple2.File.Ingest.Utils;
 using Maple2.File.IO;
 using Maple2.File.Parser;
 using Maple2.File.Parser.Enum;
+using Maple2.File.Parser.Flat.Convert;
 using Maple2.File.Parser.Xml.Table.Server;
 using Maple2.Model;
 using Maple2.Model.Common;
@@ -13,6 +12,11 @@
 using Maple2.Model.Game;
 using Maple2.Model.Game.Shop;
 using Maple2.Model.Metadata;
+using System.Globalization;
+using System.Numerics;
+using System.Reflection;
+using System.Xml;
+using Maple2.File.Parser.Xml.Table;
 using DayOfWeek = System.DayOfWeek;
 using ExpType = Maple2.Model.Enum.ExpType;
 using Fish = Maple2.File.Parser.Xml.Table.Server.Fish;
@@ -128,6 +132,10 @@ protected override IEnumerable<ServerTableMetadata> Map() {
             Name = ServerTableNames.UNLIMITED_ENCHANT_OPTION,
             Table = ParseUnlimitedEnchantOption(),
         };
+        yield return new ServerTableMetadata {
+            Name = ServerTableNames.CONSTANTS,
+            Table = ParseConstants(),
+        };
 
     }
 
@@ -2135,4 +2143,86 @@ void AddSpecial(Dictionary<SpecialAttribute, int> values, Dictionary<SpecialAttr
             }
         }
     }
+
+    private ConstantsTable ParseConstants() {
+        var constants = new ConstantsTable();
+        Dictionary<string, PropertyInfo> propertyLookup = typeof(ConstantsTable).GetProperties()
+            .ToDictionary(p => p.Name.Trim(), p => p, StringComparer.OrdinalIgnoreCase);
+
+        foreach ((string key, Constants.Key constant) in parser.ParseConstants()) {
+            string trimmedKey = key.Trim();
+            if (!propertyLookup.TryGetValue(trimmedKey, out PropertyInfo? property)) continue;
+            string cleanValue = CleanConstantsInput(
+                constant.value.Trim(),
+                trimmedKey,
+                property.PropertyType
+            );
+            SetValue(property, constants, cleanValue);
+        }
+        return constants;
+    }
+
+    private string CleanConstantsInput(string input, string propName, Type type) {
+        // check if string contains the ending 'f' for float designation, strip it if it does.
+        if (type == typeof(float) && input.Contains('f')) {
+            input = input.TrimEnd('f', 'F');
+        }
+        // 1 does not automatically equate to true during bool conversion
+        if (type == typeof(bool) && input == "1") {
+            input = "true";
+        }
+        // 0 does not automatically equate to false during bool conversion
+        if (type == typeof(bool) && input == "0") {
+            input = "false";
+        }
+        // Convert into a TimeSpan friendly input string instead of an int value
+        if (type == typeof(TimeSpan) && propName == "UgcHomeSaleWaitingTime") {
+            input = TimeSpan.FromSeconds(int.Parse(input)).ToString(); // TODO: may not be correct conversion to TimeSpan
+        }
+        // Remove prefix 0 on integers since they do not convert properly
+        if (type == typeof(int) && input[0] == '0' && input.Length > 1) {
+            input = input.Remove(0, 1);
+        }
+        return input;
+    }
+
+    private void SetValue(PropertyInfo prop, object? obj, object? value) {
+        if (obj == null && value == null || value == null) return;
+        HandleNonIConvertibleTypes(prop, ref value);
+        bool isConvertible = typeof(IConvertible).IsAssignableFrom(prop.PropertyType);
+        prop.SetValue(obj, isConvertible ? Convert.ChangeType(value, prop.PropertyType, CultureInfo.InvariantCulture) : value);
+    }
+
+    private object? HandleNonIConvertibleTypes(PropertyInfo prop, ref object? value) {
+        if (value == null) return value;
+        // Handle TimeSpan type
+        if (prop.PropertyType == typeof(TimeSpan)) {
+            // Special case - dashes (-) are used instead of colons (:)
+            if (prop.Name == "DailyTrophyResetDate") {
+                value = ((string)value).Replace('-', ':');
+            }
+            value = TimeSpan.Parse((string)value, CultureInfo.InvariantCulture);
+        }
+        // Handle array types (int[], short[], etc.)
+        if (prop.PropertyType.IsArray) {
+            var elementType = prop.PropertyType.GetElementType();
+            if (elementType == null) return value;
+            string[] segments = ((string)value).Split(',');
+            Array destinationArray = Array.CreateInstance(elementType, segments.Length);
+            for (int i = 0; i < segments.Length; i++) {
+                object convertedValue = Convert.ChangeType(segments[i].Trim(), elementType);
+                destinationArray.SetValue(convertedValue, i);
+            }
+            value = destinationArray;
+        }
+        // Handle Vector3 type
+        if (prop.PropertyType == typeof(Vector3)) {
+            string[] parts = ((string) value).Split(',');
+            if (parts.Length != 3) return value;
+            value = new Vector3(float.Parse(parts[0], CultureInfo.InvariantCulture),
+                float.Parse(parts[1], CultureInfo.InvariantCulture),
+                float.Parse(parts[2], CultureInfo.InvariantCulture));
+        }
+        return value;
+    }
 }

Maple2.Model/Common/ServerTableNames.cs

@@ -24,4 +24,5 @@ public static class ServerTableNames {
     public const string COMBINE_SPAWN = "combineSpawn*.xml";
     public const string ENCHANT_OPTION = "enchantOption.xml";
     public const string UNLIMITED_ENCHANT_OPTION = "unlimitedEnchantOption.xml";
+    public const string CONSTANTS = "constants.xml";
 }

Maple2.Model/Game/Cube/Nurturing.cs

@@ -48,20 +48,20 @@ public Nurturing(long exp, short claimedGiftForStage, long[] playedBy, DateTimeO
         }
     }
 
-    public void Feed() {
+    public void Feed(int nurturingEatGrowth) {
         if (Exp >= NurturingMetadata.RequiredGrowth.Last().Exp) {
             return;
         }
 
-        Exp += Constant.NurturingEatGrowth;
+        Exp += nurturingEatGrowth;
         if (Exp >= NurturingMetadata.RequiredGrowth.First(x => x.Stage == Stage).Exp) {
             Stage++;
         }
         LastFeedTime = DateTimeOffset.Now;
     }
 
-    public bool Play(long accountId) {
-        if (PlayedBy.Count >= Constant.NurturingPlayMaxCount) {
+    public bool Play(long accountId, int nurturingEatGrowth, int nurturingPlayMaxCount) {
+        if (PlayedBy.Count >= nurturingPlayMaxCount) {
             return false;
         }
 
@@ -70,7 +70,7 @@ public bool Play(long accountId) {
         }
 
         PlayedBy.Add(accountId);
-        Feed();
+        Feed(nurturingEatGrowth);
         return true;
     }
 

Maple2.Model/Game/Mail.cs

@@ -1,6 +1,5 @@
 using System.Text;
 using Maple2.Model.Enum;
-using Maple2.Model.Metadata;
 using Maple2.PacketLib.Tools;
 using Maple2.Tools;
 using Maple2.Tools.Extensions;
@@ -35,11 +34,19 @@ public class Mail : IByteSerializable {
     // More than 1 item may not display properly
     public readonly IList<Item> Items;
 
+    // Specifically for Mail object cloning (Mail.cs:57)
     public Mail() {
         TitleArgs = new List<(string Key, string Value)>();
         ContentArgs = new List<(string Key, string Value)>();
         Items = new List<Item>();
-        ExpiryTime = DateTimeOffset.UtcNow.AddDays(Constant.MailExpiryDays).ToUnixTimeSeconds();
+        // ExpiryTime will be overwritten, no need to set it here with a parameter passing server constant value.
+    }
+
+    public Mail(int mailExpiryDays) {
+        TitleArgs = new List<(string Key, string Value)>();
+        ContentArgs = new List<(string Key, string Value)>();
+        Items = new List<Item>();
+        ExpiryTime = DateTimeOffset.UtcNow.AddDays(mailExpiryDays).ToUnixTimeSeconds();
     }
 
     public void Update(Mail other) {

Maple2.Model/Game/Npc/Npc.cs

@@ -10,8 +10,16 @@ public class Npc {
 
     public bool IsBoss => Metadata.Basic.Friendly == 0 && Metadata.Basic.Class >= 3;
 
-    public Npc(NpcMetadata metadata, AnimationMetadata? animation) {
-        Metadata = metadata;
+    public Npc(NpcMetadata metadata, AnimationMetadata? animation, float constLastSightRadius, float constLastSightHeightUp, float constLastSightHeightDown) {
+        if (metadata.Distance.LastSightRadius == 0) {
+            Metadata = new NpcMetadata(metadata, constLastSightRadius);
+        } else if (metadata.Distance.LastSightRadius == 0 && metadata.Distance.LastSightHeightUp == 0) {
+            Metadata = new NpcMetadata(metadata, constLastSightRadius, constLastSightHeightUp);
+        } else if (metadata.Distance.LastSightRadius == 0 && metadata.Distance.LastSightHeightUp == 0 && metadata.Distance.LastSightHeightDown == 0) {
+            Metadata = new NpcMetadata(metadata, constLastSightRadius, constLastSightHeightUp, constLastSightHeightDown);
+        } else {
+            Metadata = metadata;
+        }
         Animations = animation?.Sequences ?? new Dictionary<string, AnimationSequenceMetadata>();
     }
 }

Maple2.Model/Game/User/StatAttributes.cs

@@ -13,9 +13,9 @@ public class StatAttributes : IByteSerializable {
     public int TotalPoints => Sources.Count;
     public int UsedPoints => Allocation.Count;
 
-    public StatAttributes() {
+    public StatAttributes(IDictionary<string, int> statLimits) {
         Sources = new PointSources();
-        Allocation = new PointAllocation();
+        Allocation = new PointAllocation(statLimits);
     }
 
     public void WriteTo(IByteWriter writer) {
@@ -52,14 +52,15 @@ public void WriteTo(IByteWriter writer) {
 
     public class PointAllocation : IByteSerializable {
         private readonly Dictionary<BasicAttribute, int> points;
+        private readonly IDictionary<string, int> statLimits;
 
         public BasicAttribute[] Attributes => points.Keys.ToArray();
         public int Count => points.Values.Sum();
 
         public int this[BasicAttribute type] {
             get => points.GetValueOrDefault(type);
             set {
-                if (value < 0 || value > StatLimit(type)) {
+                if (value < 0 || value > StatLimit(type, statLimits)) {
                     return;
                 }
                 if (value == 0) {
@@ -71,19 +72,20 @@ public int this[BasicAttribute type] {
             }
         }
 
-        public PointAllocation() {
+        public PointAllocation(IDictionary<string, int> statLimits) {
             points = new Dictionary<BasicAttribute, int>();
+            this.statLimits = statLimits;
         }
 
-        public static int StatLimit(BasicAttribute type) {
+        public static int StatLimit(BasicAttribute type, IDictionary<string, int> statLimits) {
             return type switch {
-                BasicAttribute.Strength => Constant.StatPointLimit_str,
-                BasicAttribute.Dexterity => Constant.StatPointLimit_dex,
-                BasicAttribute.Intelligence => Constant.StatPointLimit_int,
-                BasicAttribute.Luck => Constant.StatPointLimit_luk,
-                BasicAttribute.Health => Constant.StatPointLimit_hp,
-                BasicAttribute.CriticalRate => Constant.StatPointLimit_cap,
-                _ => 0,
+                BasicAttribute.Strength => statLimits.GetValueOrDefault("StatPointLimit_str"),
+                BasicAttribute.Dexterity => statLimits.GetValueOrDefault("StatPointLimit_dex"),
+                BasicAttribute.Intelligence => statLimits.GetValueOrDefault("StatPointLimit_int"),
+                BasicAttribute.Luck => statLimits.GetValueOrDefault("StatPointLimit_luk"),
+                BasicAttribute.Health => statLimits.GetValueOrDefault("StatPointLimit_hp"),
+                BasicAttribute.CriticalRate => statLimits.GetValueOrDefault("StatPointLimit_cap"),
+                _ => 0
             };
         }