feat: inventory full duplicate message fix#27
Open
JosTheDude wants to merge 2 commits into
Open
Conversation
Author
|
Still prod testing this then will swap to ready for review! |
Author
|
Confirmed & ready for merge - prod tested running latest Folia w/ around 200+ players. |
Author
|
@MackenzieMolloy It looks like some of the PRs here take a bit for visibility, so I'm mentioning as this is a bug patch rather than a feature addition or similar ^-^ |
Owner
|
This PR looks good however please remove the plugin version bump (1.1.9). |
Author
Done! This was mostly for our reference to indicate we were running the updated version, shouldn't have included that here 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patches a minor visual issue with the error message regarding a full inventory when selling an unsellable item.
What's the issue?
The /sellgui function gives an incorrect error message when attempting to place an unsellable item into the GUI. It says the player’s inventory is full and excess items were dropped on the ground, even when the inventory has plenty of empty space.
Steps to reproduce:
Open /sellgui.
Have empty inventory slots available.
Attempt to place an unsellable item into the sell GUI.
Observe the message:
“Shop > Your inventory is currently full, so excess items have been dropped on the ground.”
Expected result:
The GUI should either:
reject the item with a message stating the item is unsellable, or
return the item normally without claiming the inventory is full.
Actual result:
The system displays an inventory full message and claims items were dropped, even when the player has available inventory space.
What's this PR do?
Patches that! :D
Credit to @Tarmk for the original issue report in our servers' discord