GO3 model typo fix, Julia 1.12, ExaModel 0.11, and MadNLP 0.10#44
Open
michel2323 wants to merge 11 commits into
Open
GO3 model typo fix, Julia 1.12, ExaModel 0.11, and MadNLP 0.10#44michel2323 wants to merge 11 commits into
michel2323 wants to merge 11 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 89.18% 89.42% +0.23%
==========================================
Files 9 9
Lines 1313 1314 +1
==========================================
+ Hits 1171 1175 +4
+ Misses 142 139 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MadNLP 0.10 recovers multipliers via jtprod! when finalizing solver stats, and the ExaModels KernelAbstractions extension only supports jtprod_nln! when the model carries a Prodhelper. Without it, any solve on a KA backend (CPU()/CUDABackend()) errors with "Prodhelper is not defined". Callers can still override via kwargs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ExaCore(T; backend) warns that it returns the deprecated mutable LegacyExaCore, but the builders and the public user_callback contract still need the mutating API (variable/constraint/constraint!), which only exists for LegacyExaCore. Construct the wrapper directly via a legacy_core helper until the package migrates to the functional add_var/add_con API. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
michel2323
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks, Claude.