refactor(autostart): remove legacy guards, require lich 5.17.2+#1
Closed
MahtraDR wants to merge 2 commits into
Closed
refactor(autostart): remove legacy guards, require lich 5.17.2+#1MahtraDR wants to merge 2 commits into
MahtraDR wants to merge 2 commits into
Conversation
Core lich 5.17.2+ provides get_settings, start_scripts_if_available, and Map.apply_wayto_overrides natively. Remove the respond_to? guards and the entire legacy DR dependency install path that predated these. Changes: - Remove legacy DR dependency path (first-run install, old lich fallback) - Remove respond_to?(:get_settings) guard (always true on 5.17.2+) - Remove Map.respond_to?(:apply_wayto_overrides) guard (always true) - Remove Gem::Version lich5-update check (5.17.2 > 5.6.2 always) - Consolidate lich5-update into the skip list - Update comment: dependency loads for runtime helpers, not parse_args - Bump version to 0.72, required to Lich >= 5.17.2 - Update spec helpers to match simplified code Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
autostart.lic is game-agnostic (game: any). GS players on older lich may not have get_settings, Map.apply_wayto_overrides, or Lich::Util::Update. Restore respond_to? guards for these while keeping the DR legacy path removal (dependency.lic enforces 5.17.2). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
|
Retargeting to upstream elanthia-online/scripts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
respond_to?(:get_settings)andMap.respond_to?(:apply_wayto_overrides)guards -- always true on 5.17.2+Gem::Versionlich5-update version check -- always true on 5.17.2+lich5-updateinto the static skip listNet: -79 lines (+30 / -109)
Companion PR
dependency.lic strip (dr-scripts): MahtraDR/dr-scripts#3 -- removes all gated dead code, bumps to v4.0.0.
Test plan
bundle exec rspec spec/autostart/autostart_spec.rb-- 49 examples, 0 failures🤖 Generated with Claude Code