Skip to content

remove clip from module item to fix cropped icon#802

Open
romanstingler wants to merge 1 commit into
MalpenZibo:mainfrom
romanstingler:fix/cropped-module-icon
Open

remove clip from module item to fix cropped icon#802
romanstingler wants to merge 1 commit into
MalpenZibo:mainfrom
romanstingler:fix/cropped-module-icon

Conversation

@romanstingler

Copy link
Copy Markdown
Collaborator

Removing .clip(true) from module item containers prevents icons from being cropped when they extend beyond element bounds.

Before
image
After
image

With vk and gl renderer
with ICED_BACKEND=tiny-skia is always renders fine on my machine.

sorry for the small screenshots.

closes #571

@github-actions github-actions Bot added the bug Something isn't working label Jun 8, 2026
@MalpenZibo

Copy link
Copy Markdown
Owner

Hmm! This makes sense, but:

  • I suspect that the problem is in something like "how cosmic-text" calculates the width of some glyph
  • This causes a secondary issue: if things like the window title are too long (something happens to me), the text goes on a new line. So, to resolve an issue that I never noticed on my machine (it seems to depend on some machine configuration), we're causing an issue that will happen everywhere

@romanstingler

Copy link
Copy Markdown
Collaborator Author

what??
" if things like the window title are too long (something happens to me), the text goes on a new line"

there are dots in the middle and the text is shortened. (top latest main, bottom branch)
image

@MalpenZibo

Copy link
Copy Markdown
Owner
image This is what happens to me when I fill the space. I can reduce the maximum number of title characters, but if I set that value too high, the clip property truncates the end of the title. Without it, the text will go to the next line.

I will try to make more test about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Update module icon is cropped

2 participants