Maze realization and backends#3
Open
seanrivera wants to merge 9 commits into
Open
Conversation
pranavguru
requested changes
May 1, 2026
Member
pranavguru
left a comment
There was a problem hiding this comment.
A couple of overall comments:
- Seems like there are quite a few duplicate, identical files with the #2 branch - this shouldn't be the case. Increases bloat on the PRs
- Since MultiGrid is not immediate priority and not on the critical path for the first few set of experiments we need to run, the modules related to MultiGrid can be reviewed later
79f72a5 to
55e6ada
Compare
Member
|
The duplicate files issue hasn't been addressed yet right? @seanrivera |
… the running environment, including the interfaces, includes multigrid for contaimination and spatial issues. Essentially this is the meat of the running pipeline.
… small Multigrid rendering issues
55e6ada to
3e36ee7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 2 of the 4 part review requests. Feel free to split them among people as needed. This one is just the Minigrid/Multigrid codebase.