Conversation
pranavguru
requested changes
Apr 30, 2026
Member
pranavguru
left a comment
There was a problem hiding this comment.
We should handle the submodule better - I think we faced similar issues in v1.0 where the pi0 submodule was not updated and synced. We should not let that happen with v2.0.
Member
There was a problem hiding this comment.
does this file need to be pushed to the repo? Seems like a developer config file
Member
There was a problem hiding this comment.
Submodule is unclonable. Two independent issues:
- .gitmodules declares url = ./ogbench. Git resolves relative submodule URLs against the parent repo's origin, producing https://github.com/ManifoldRG/MultiNet-v2.0.git/ogbench, which doesn't exist. Repro:
$ git submodule update --init --recursive
fatal: repository 'https://github.com/ManifoldRG/MultiNet-v2.0.git/ogbench/' not found
-
Fix: replace with an absolute URL.
-
The pinned SHA d7509418e7a2243ebea3c5fc081ed57557e89719 is not reachable on canonical seohongpark/ogbench:
$ git ls-remote https://github.com/seohongpark/ogbench.git | grep d7509418
(no output)
- So even after fixing the URL, the submodule won't resolve unless we point at the fork that actually contains those commits
Before merging, we need to:
- Confirm where SHA d7509418e7… actually lives. If it's on a personal fork, push it to a ManifoldRG/ogbench fork instead so the pin doesn't depend on a personal account.
- Update .gitmodules to the absolute URL of that fork.
- Open an upstream PR (or a long-running fork branch) for the OGBench-internal D2 maze fixes, so we have a path to eventually re-sync with seohongpark/ogbench and not maintain a permanent fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just adding ogbench as a submodule