chore(nlu): track benchmark_solver PNGs and CSV for review#9
Open
arushi-jain-27 wants to merge 5 commits into
Open
chore(nlu): track benchmark_solver PNGs and CSV for review#9arushi-jain-27 wants to merge 5 commits into
arushi-jain-27 wants to merge 5 commits into
Conversation
69b652b to
9ef7aa3
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
b7fb2fb to
337e043
Compare
Drop benchmark_mazes_metadata.csv from version control; smoke still writes it locally. Ignore *.csv under benchmark_solver/. Co-authored-by: Cursor <cursoragent@cursor.com>
337e043 to
30fc5b7
Compare
Version benchmark_mazes_metadata.csv under smoke_tests/results/benchmark_solver/; stop ignoring *.csv there so the whole benchmark_solver output set is committed. Co-authored-by: Cursor <cursoragent@cursor.com>
…derer Re-run smoke_benchmark_mazes.py on pr1-aligned code so committed PNGs and CSV match local renders after rendering/coordinate fixes (be38a58 and stack). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@helenlu66 @pranavguru: This branch has validated mazes using my BFS solver.
It looks like 212/214 mazes pass validation. The 2 mazes that are failing are the corridor mazes in M6 where the walls are actually blocking the path to the goal.