Repository navigation
Inspector (Mono): Fix multi-dimensional arrays - #134
Merged
Merged
Conversation
ManlyMarco
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MemberCollector would send arrays to the ListCacheEntry, which would try accessing the element of the array with _list[_index]. This fails for multidimensional arrays throwing an ArgumentException "Only single dimensional arrays are supported for the requested action." for every element, every frame.
Simplest solution would be to have arrays with Rank > 1 fall through to the IEnumerable path, but that would flatten the items in the array into one dimension in the list that opens. I therefor implemented a new ArrayCacheEntry that (for multidimensional arrays) constructs the item label as "Index: [X, Y, ...]". One-dimensional arrays are also handled by it now. Last but not least it should also handle arrays with a lower index bound that is not 0.