chore(helm): dedupe dashboard JSON + untrack chart build artifact#25
Merged
Conversation
- Remove duplicate root grafana/maps-playground-dashboard.json; the Grafana dashboard now lives only under helm/grafana/, where the ConfigMap's chart-relative .Files.Get already reads it. - Drop helm/grafana/dashboard-sync.test.ts (nothing left to keep in sync). - Untrack helm/charts/*.tgz and gitignore it — a build artifact regenerated from Chart.lock via `helm dependency build`, not source. - Also gitignore docs/ and helm/values-*.yaml to stop stray local files from being committed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge cleanup of the metrics/dashboard work from #22.
grafana/maps-playground-dashboard.json. The dashboard now lives only underhelm/grafana/, where the ConfigMap's chart-relative.Files.Getalready reads it. Dropped the now-pointlessdashboard-sync.test.ts.helm/charts/mclabels-1.0.1.tgzis regenerated from the committedChart.lockviahelm dependency build; it is runtime output, not source.git rm --cached+ gitignorehelm/charts/*.tgz.docs/andhelm/values-*.yamlso stray local files stop being staged.Test Plan
npm test→ 34/34 passhelm dependency build helm/ && helm template helm/ --set enabled=truerenders the dashboard ConfigMap (readshelm/grafana/copy).tgzis git-ignored (only staged deletion remains)🤖 Generated with Claude Code