Repository navigation
Dock grabber: measure the drag in window coordinates (from #417) - #473
Draft
McCal-Codes wants to merge 2 commits into
Draft
McCal-Codes wants to merge 2 commits into
McCal-Codes wants to merge 2 commits into
Conversation
… dock follows the finger (#326)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries itxjobe's change from #417 onto a branch in this repo so CI can run, with main merged in (only CHANGELOG.md conflicted; both sides kept). The code is theirs, unchanged: the dock grabber sits at the dock's top, so it moves under the finger while you drag, and a drag measured in the grabber's own coordinates collapses. Measuring in window coordinates fixes that.
What I checked: compile and the full unit suite on this branch (1543 tests, 0 failures, 8 skipped), including their DockGrabberTest.
What I have not checked: the drag on the Fold8 in edit mode, slow and fast, or the TalkBack Move Up and Down actions. That is the next step before it goes into a beta.
If this merges, #417 can be closed as carried over, with thanks to itxjobe.