Skip to content

Fix #824: For 2.2 membership must accept datasets without identifiers#826

Merged
mla2001 merged 6 commits into
1.9.Xfrom
cr-824
Jun 11, 2026
Merged

Fix #824: For 2.2 membership must accept datasets without identifiers#826
mla2001 merged 6 commits into
1.9.Xfrom
cr-824

Conversation

@mla2001

@mla2001 mla2001 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Membership can now be executed with non ids datasets

Checklist

  • Code quality checks pass (ruff format, ruff check, mypy)
  • Tests pass (pytest)
  • Documentation updated (if applicable)

@mla2001 mla2001 self-assigned this Jun 10, 2026
@mla2001 mla2001 requested review from a team and javihern98 June 10, 2026 15:55
@mla2001 mla2001 changed the title Fix #824 Fix #824: For 2.2 membership must accept datasets without identifiers Jun 10, 2026

@javihern98 javihern98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution is not correct. It is required to return in this case a scalar object and ensure the semantic analysis handles it correctly.

@mla2001 mla2001 requested a review from javihern98 June 11, 2026 10:22

@javihern98 javihern98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!😊

@mla2001 mla2001 enabled auto-merge (squash) June 11, 2026 10:46
@mla2001 mla2001 merged commit a6653ff into 1.9.X Jun 11, 2026
17 checks passed
@mla2001 mla2001 deleted the cr-824 branch June 11, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants