fix: Fix duplicated note blank page - EXO-87922#1707
Merged
Conversation
Prior to this change, when duplicating a note, a blank page is displayed. This is caused by the fact that "canRedact" prop value is computed from NotesEditorDashboard component then passed to NoteFullRichEditor component only when the url notes-editor url contains "parentNoteId" param which is not the case for duplicated note url like "notes-editor?noteId=XX&translation=&spaceGroupId=XXXXX" After this commit, we will ensure to compute "canRedact" prop value even without "parentNoteId" url param which covers also the duplicated note case.
azayati
changed the title
boubaker
approved these changes
Jun 25, 2026
|
exo-swf
pushed a commit
that referenced
this pull request
Jun 25, 2026
Prior to this change, when duplicating a note, a blank page is displayed. This is caused by the fact that "canRedact" prop value is computed from NotesEditorDashboard component then passed to NoteFullRichEditor component only when the url notes-editor url contains "parentNoteId" param which is not the case for duplicated note url like "notes-editor?noteId=XX&translation=&spaceGroupId=XXXXX" After this commit, we will ensure to compute "canRedact" prop value even without "parentNoteId" url param which covers also the duplicated note case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, when duplicating a note, a blank page is displayed. This is caused by the fact that "canRedact" prop value is computed from NotesEditorDashboard component then passed to NoteFullRichEditor component only when the url notes-editor url contains "parentNoteId" param which is not the case for duplicated note url like "notes-editor?noteId=XX&translation=&spaceGroupId=XXXXX" After this commit, we will ensure to compute "canRedact" prop value even without "parentNoteId" url param which covers also the duplicated note case.