Implement Coins List Endpoint with Pagination and Sorting#2
Open
HermanKoii wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Coins List Endpoint with Pagination and Sorting
Description
Task
Create a new route for coins list endpoint that returns a list of available cryptocurrencies from the existing crypto-prices.json data
Acceptance Criteria
Summary of Work
This pull request adds a comprehensive coins list endpoint that retrieves cryptocurrency data with advanced filtering and pagination capabilities.
Changes Made:
getCoinsListfunction insrc/routes/coins.tscrypto-prices.jsondata sourcesrc/routes/index.tsImplementation Details:
/coins/marketsorder: Sorting order (default: 'market_cap_desc')per_page: Number of results per page (min: 1, max: 250, default: 100)page: Page number for pagination (default: 1)Potential Improvements:
Changes Made
Tests
Signatures
Staking Key
3JF13GJW2UeYuTTRJQBdBD9bHP6Zj1QLMyXBMoAP2r5Y: HgySJASzxerYsEHKV3RQduDUfXLXRNxtB67xfTbBeEkL8ty8USRaivm2ECDG2qZqGjSbQtRXVAmLadnWcBGwU6pmdTov1DHDaQrT6m8UyCuyx2YXCvXvYN9pU11WvB4659zFZJVgjHLh3EKsbY5SFazQCE9xE5AsnZZPVsUYq3VBpDUUrj4KBSsNDLEC7Kt9C6TTq2P6Ks6cGruLYdyiy7i6b3pDEva97PhRi3BS5c65uCg5CNB4cuvFbcCNQcSbXdQ9PeKamFFCz3yVTsfLGZgEDveLA2weFuWhqEXpsJZzXaWa3Ga5MGFvw3R8rNwN7VQjT9w1E4i8Smd5gkuNvuDpCUxRhpxxafE6fdZW3XfTdMGKjLZm5H39t5q612zKPCkoUG6jsCBqx7G37jN1ce37H5KMtqHUQU
Public Key
H2j8Cz7zKCeuDTs73vtjDtBmtytQX1JyaQqvYwwQWE6p: 37DYv55LKtp9gtuJCaY6tqci6ZYzoFKbLrfTRzRDypDEjhwzuHpXY54g6xjRGYZ6A2bw5ZSHLxuzac34XeR8afLZAu6Qktcnbg3i1ri1wcqArrn7RVioawuJsygkhMK8VMJ8R8X5WdKCS64odWGYSb5BaAKEKCCt9X59GmpMAeKj1NYXCmUhBw3jz5x5AwXWcwCLKXujPU9W9k6ET5KFFzWfJMTffxjJgrWkhHtmuS34ybnEJNje8SHZG749zCvSywaoY6zfiuN7jxCstSD83HMeUcGhWyvCGBT1cE1PpsHK4MrpX4XLDZLcSwZapAGiCJhYfys4x9WSzTvvVix5JqUdQAn2HNjERHunpjZvUcdpXm8dvfiX2LL22D3K1GbU53MmmG5KXFZU6Aj7GzKPMbo398fry2Uycg