Open
Conversation
adalisk-emikhaylov
added
the
skip-image-rebuild
oitel
reviewed
Apr 14, 2026
Comment on lines
+142
to
+144
| CMAKE_OPTIONS="${MR_CMAKE_OPTIONS}" ${SCRIPT_DIR}/thirdparty/nlohmann-json.sh "$MESHLIB_THIRDPARTY_DIR/nlohmann-json" | ||
| # Build cpp-httplib separately. It is header-only, this just installs it. It is a dependency of fastmcpp. | ||
| CMAKE_OPTIONS="${MR_CMAKE_OPTIONS}" ${SCRIPT_DIR}/thirdparty/cpp-httplib.sh "$MESHLIB_THIRDPARTY_DIR/cpp-httplib" |
Contributor
There was a problem hiding this comment.
Could they be parts of the thirdparty/CMakeLists.txt?
| export HOME=${RUNNER_TEMP} | ||
| git config --global --add safe.directory ${GITHUB_WORKSPACE} | ||
| git submodule update --init --recursive --depth 1 thirdparty/imgui thirdparty/mrbind-pybind11 thirdparty/mrbind | ||
| git submodule update --init --recursive --depth 1 thirdparty/imgui thirdparty/mrbind-pybind11 thirdparty/mrbind thirdparty/fastmcpp thirdparty/nlohmann-json thirdparty/cpp-httplib |
Contributor
There was a problem hiding this comment.
Can we use nlohmann-json and cpp-httplib versions from vcpkg?
| run: | | ||
| # Download sub-submodules for certain submodules. We don't recurse above in Checkout to improve build performance. See: https://github.com/actions/checkout/issues/1779 | ||
| git submodule update --init --recursive --depth 1 thirdparty/mrbind | ||
| git submodule update --init --recursive --depth 1 thirdparty/mrbind thirdparty/fastmcpp thirdparty/nlohmann-json thirdparty/cpp-httplib |
Contributor
There was a problem hiding this comment.
Can we use nlohmann-json and cpp-httplib versions from vcpkg?
adalisk-emikhaylov
removed
the
skip-image-rebuild
Grantim
reviewed
Apr 15, 2026
| // NOTE: Consult `docs/testing_mcp.md` for how to test your tool. | ||
| MRMCP_API bool addTool( std::string id, std::string name, std::string desc, Schema::Base inputSchema, Schema::Base outputSchema, ToolFunc func ); | ||
|
|
||
| [[nodiscard]] MRMCP_API Params getParams() const; |
Contributor
Author
There was a problem hiding this comment.
It might not be initialized yet, in which case I return default-constructed params.
Contributor
There was a problem hiding this comment.
is Server singleton or we expecting more then one? why store params_ in State while we can store it directly in Server? (in general why have two separate classes?)
Comment on lines
+140
to
+142
| // Returns true on success, including if the server is already running and you're trying to start it again. | ||
| // Stopping always returns true. | ||
| MRMCP_API bool setRunning( bool enable ); |
Contributor
Author
There was a problem hiding this comment.
Then run( false ) looks weird to me.
Contributor
There was a problem hiding this comment.
mb toggle(bool on) or enable(bool) (we have enable in other places)
Contributor
There was a problem hiding this comment.
should this file also contain addition of default MCP tools?
Contributor
There was a problem hiding this comment.
Join this file wtih MRSetupMCP.cpp?
Contributor
Author
There was a problem hiding this comment.
I'd rather keep them separate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.