CMake: Fix fastmcpp build#5953
Merged
Merged
Conversation
oitel
added
skip-image-rebuild
This reverts commit a5493da.
oitel
added
disable-build-macos
skip-image-rebuild
oitel
added
skip-image-rebuild
Grantim
approved these changes
Apr 29, 2026
| # TODO: why does it affect only Linux+vcpkg? | ||
| if(CMAKE_SYSTEM_NAME STREQUAL "Linux" AND MESHLIB_USE_VCPKG) | ||
| # fix missing references to 'getaddrinfo_a' and 'gai_*' functions (required by cpp-httplib) | ||
| target_link_libraries(${PROJECT_NAME} PRIVATE anl) |
Contributor
Author
There was a problem hiding this comment.
The function calls are internal.
Comment on lines
+17
to
+45
| "default-features": [ | ||
| "brotli" | ||
| ], | ||
| "features": { | ||
| "brotli": { | ||
| "description": "Enables brotli compression support using brotli", | ||
| "dependencies": [ | ||
| "brotli" | ||
| ] | ||
| }, | ||
| "openssl": { | ||
| "description": "Enables HTTPS support using OpenSSL", | ||
| "dependencies": [ | ||
| "openssl" | ||
| ] | ||
| }, | ||
| "zlib": { | ||
| "description": "Enables gzip compression support using zlib", | ||
| "dependencies": [ | ||
| "zlib" | ||
| ] | ||
| }, | ||
| "zstd": { | ||
| "description": "Enables zstd support", | ||
| "dependencies": [ | ||
| "zstd" | ||
| ] | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
No, it's an exact copy of modern cpp-httplib version for VS2019.
adalisk-emikhaylov
approved these changes
Apr 29, 2026
MaxRayskiy
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.