ci: retry upload-artifact via Wandalen/wretry.action#5975
Merged
Conversation
…MeshInspectorCode#7234)
…s MeshInspectorCode#7234)
…low-list Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The wrapped steps are self-documenting via the Wandalen/wretry.action usage. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Grantim
approved these changes
Apr 24, 2026
2 tasks
Fedr
added a commit
that referenced
this pull request
Apr 30, 2026
Most of our Windows CI runs on github-hosted runners, where transient DNS / connect failures are not an issue, so the wretry.action wrapper that #5975 added isn't carrying its weight there. It is also noisy: on Windows, every wretry-wrapped step emits Warning: Environment variable 'INPUT_GITHUB_CONTEXT' exceeds the maximum supported length. Environment variable length: 39289 , Maximum supported length: 32766 because wretry forwards `toJson(github)` via `INPUT_GITHUB_CONTEXT`, which exceeds Windows' 32767-char env var limit. See Wandalen/wretry.action#192. The macOS workflow keeps the wrapper, since those runners are self-hosted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wraps each
actions/upload-artifact@v7step in the Windows and macOS workflows withWandalen/wretry.actionso transient self-hosted-runner network flakes during artifact upload (typicallyENOTFOUNDonCreateArtifact) no longer fail the whole build.actions/upload-artifact@v7retries transient twirpRequest timeouts internally but treatsENOTFOUND/ DNS errors as fatal — a ~45-minute build is lost to a one-second DNS blip. Our self-hosted runners have exhibited this failure mode intermittently.Change
6
actions/upload-artifact@v7steps wrapped:.github/workflows/build-test-macos.yml—Upload Macos Distribution+Upload NuGet files to Artifacts.github/workflows/build-test-windows.yml—Upload Windows Binaries Archive+Upload MeshLibC2 headers archive+Upload NuGet files to Artifacts+Upload NuGet library DLL and XML to ArtifactsEach wrap:
3 attempts × 30 s delay covers a typical 1-minute github.com blip.
overwrite: truelets a retry replace a partial artifact atomically (upload-artifact@v4+ finalises atomically, so this is safe).Scope
Only the self-hosted-runner workflows (Windows + macOS arm64/Release matrix leg). The other upload-artifact sites run on GitHub-hosted runners and haven't exhibited this failure mode;
disable-build-*labels suppress non-Windows / non-macOS CI in this PR.Note: this PR intentionally does not wrap
actions/checkout— a separate attempt to do so (#5969) hit astartup_failurewhen wretry's composite layer tried to dispatch aroundactions/checkout@v6. That PR now uses an in-workflow git-submodule retry loop instead.actions/upload-artifact@v7doesn't trigger the same parse-time refusal.Test plan
CreateArtifacthits a transient 5xx /ENOTFOUND: retry kicks in, job still succeeds.