fix: reject Uncategorized heading in any release during validation#278
Open
skyc1e wants to merge 1 commit into
Open
fix: reject Uncategorized heading in any release during validation#278skyc1e wants to merge 1 commit into
skyc1e wants to merge 1 commit into
Conversation
Previously, the Uncategorized change category was only rejected for the current release when isReleaseCandidate was set. This meant Uncategorized entries could slip through in older releases or when running validation outside of release candidate mode. Now validation always fails if any release contains an Uncategorized heading, regardless of isReleaseCandidate. Fixes MetaMask#207
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Validation previously only rejected
Uncategorizedchange categories for the current release whenisReleaseCandidatewas set totrue. This meantUncategorizedentries could remain undetected in older releases or when running validation outside of release candidate mode.This change moves the Uncategorized check out of the
isReleaseCandidateblock and applies it to all releases unconditionally, so any changelog containing an### Uncategorizedheading will fail validation.References
Fixes #207
Changelog
Changed
Uncategorizedheadings in any release, regardless ofisReleaseCandidatesettingChecklist
Note
Medium Risk
Tightens validation rules and may cause previously-valid changelogs/pipelines to fail, but change is small and localized to changelog validation.
Overview
Changelog validation is now stricter.
validateChangelognow scans all releases and throwsUncategorizedChangesErrorif any release containsChangeCategory.Uncategorized, regardless of theisReleaseCandidateflag.Tests were updated to reflect the new behavior, changing prior expectations that uncategorized entries could be allowed in non-RC mode or older releases.
Written by Cursor Bugbot for commit f25e8e3. This will update automatically on new commits. Configure here.