fix: pin fflate to 0.8.2 to work around attw tarball-read crash#288
Merged
Conversation
Merged
Mrtenz
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins fflate because 0.8.3 changed Gunzip's streaming callback to emit trailing empty chunks at end-of-stream. @arethetypeswrong/core (via @andrewbranch/untar.js) captures only the last chunk, so it gets an empty buffer, returns [] from untar, and crashes with "Cannot read properties of undefined (reading 'filename')" in the Compatibility test job of #287
Note
Low Risk
Low risk: dependency resolution-only change that pins
fflateto a known-good version to stabilize the test/tooling pipeline.Overview
Pins transitive dependency
fflateto0.8.2using Yarnresolutionsto avoid a regression that breaksattw --pack.Updates
yarn.lockto reflect the forcedfflate@0.8.2resolution (removing the^0.8.2range entry).Reviewed by Cursor Bugbot for commit 2c5e6fe. Bugbot is set up for automated code reviews on this repo. Configure here.