Skip to content

fix: pin fflate to 0.8.2 to work around attw tarball-read crash#288

Merged
hmalik88 merged 1 commit into
mainfrom
hm/pin-fflate
May 19, 2026
Merged

fix: pin fflate to 0.8.2 to work around attw tarball-read crash#288
hmalik88 merged 1 commit into
mainfrom
hm/pin-fflate

Conversation

@hmalik88
Copy link
Copy Markdown
Contributor

@hmalik88 hmalik88 commented May 19, 2026

Pins fflate because 0.8.3 changed Gunzip's streaming callback to emit trailing empty chunks at end-of-stream. @arethetypeswrong/core (via @andrewbranch/untar.js) captures only the last chunk, so it gets an empty buffer, returns [] from untar, and crashes with "Cannot read properties of undefined (reading 'filename')" in the Compatibility test job of #287


Note

Low Risk
Low risk: dependency resolution-only change that pins fflate to a known-good version to stabilize the test/tooling pipeline.

Overview
Pins transitive dependency fflate to 0.8.2 using Yarn resolutions to avoid a regression that breaks attw --pack.

Updates yarn.lock to reflect the forced fflate@0.8.2 resolution (removing the ^0.8.2 range entry).

Reviewed by Cursor Bugbot for commit 2c5e6fe. Bugbot is set up for automated code reviews on this repo. Configure here.

@hmalik88 hmalik88 requested a review from a team as a code owner May 19, 2026 17:55
@hmalik88 hmalik88 mentioned this pull request May 19, 2026
@hmalik88 hmalik88 merged commit 5684b5d into main May 19, 2026
26 checks passed
@hmalik88 hmalik88 deleted the hm/pin-fflate branch May 19, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants