fix: price Forma native TIA via zero-address native asset#8873
Open
jeremytsng wants to merge 4 commits into
Open
fix: price Forma native TIA via zero-address native asset#8873jeremytsng wants to merge 4 commits into
jeremytsng wants to merge 4 commits into
Conversation
Request Forma's (eip155:984122) native gas token TIA as the zero-address native asset (erc20:0x0) instead of a non-canonical SLIP-44 reference, so the Price API resolves it via the CoinGecko celestia platform mapping.
maxime-oe
previously approved these changes
May 21, 2026
maxime-oe
approved these changes
May 21, 2026
bergarces
reviewed
May 21, 2026
| '0xdef1': 'eip155:57073/slip44:60', // Ink Mainnet - Native symbol: ETH | ||
| '0x3dc': 'eip155:988/erc20:0x779ded0c9e1022225f8e0630b35a9b54be713736', // Stable - Native symbol: USDT0 | ||
| '0xf043a': 'eip155:984122/slip44:984122', // Forma - Native symbol: TIA (Celestia) | ||
| '0xf043a': 'eip155:984122/erc20:0x0000000000000000000000000000000000000000', // Forma - Native symbol: TIA (Celestia) |
Contributor
There was a problem hiding this comment.
This returns nothing in price-api (so does the slip44).
Contributor
There was a problem hiding this comment.
This chain is not supported by price-api. I'm unsure as to why it was added here in the first place, but should be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Forma (
eip155:984122) is an EVM rollup whose native gas token is TIA (Celestia).assets-controllerscurrently requests Forma's native spot price aseip155:984122/slip44:984122, a chain-ID-derived SLIP-44 reference.We should not invent non-canonical SLIP-44 references. SLIP-44 coin types are a registry of real, assigned coin types and are not equivalent to chain IDs (they are not 1:1 — e.g.
slip44:56is EDRCoin, while Binance Smart Chain's native isslip44:714). TIA/Celestia has no registered SLIP-44 coin type, soslip44:984122is a made-up value, and984122could be assigned to another network in the future.This change switches Forma's native token to the zero-address native convention —
eip155:984122/erc20:0x0000000000000000000000000000000000000000— the same representation already used for other non-ETH natives inSPOT_PRICES_SUPPORT_INFO(e.g. Hemi, BOB, Berachain). The Price API resolves this to the CoinGeckocelestiacoin via a platform mapping. No SLIP-44 reference is invented, and nochainIdToNativeTokenAddressentry is needed (zero address is the default).References
Checklist
Note
Low Risk
Low risk: a single CAIP-19 mapping change for Forma’s native asset that only affects spot price resolution for chain
984122. Potential impact is limited to Forma native pricing if downstream APIs interpret the zero-address differently.Overview
Fixes Forma (chain
984122) native token (TIA) spot price resolution by changing itsSPOT_PRICES_SUPPORT_INFOentry fromslip44:984122to the zero-address native asset (erc20:0x0000000000000000000000000000000000000000).Adds a
CHANGELOG.mdFixed entry documenting the correction.Reviewed by Cursor Bugbot for commit 11688c7. Bugbot is set up for automated code reviews on this repo. Configure here.