refactor(snap-account-service)!: make init sync + use it in ctor#8877
Open
ccharly wants to merge 2 commits into
Open
refactor(snap-account-service)!: make init sync + use it in ctor#8877ccharly wants to merge 2 commits into
ccharly wants to merge 2 commits into
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Making
initsynchronous to simplify service's lifecycle.References
N/A
Checklist
Note
Medium Risk
This is a breaking lifecycle change: callers can no longer explicitly
await init(), and seeding of tracked snaps now happens during construction, which may affect consumers that relied on deferred initialization order.Overview
Removes the async
init()lifecycle fromSnapAccountService/SnapTrackerand instead seeds tracked account-management Snaps synchronously duringSnapTrackerconstruction (called from the service constructor).Updates unit tests to no longer call
init()and to expect Snap tracking/ensureReadybehavior to be based on constructor-time seeding, and records the breaking removal in the package changelog.Reviewed by Cursor Bugbot for commit 9fb8d00. Bugbot is set up for automated code reviews on this repo. Configure here.