Skip to content

refactor: Use permission decoders from @metamask/7715-permission-types #9164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffsmale90 wants to merge 8 commits into
base: main
Choose a base branch
from
Open

refactor: Use permission decoders from @metamask/7715-permission-types #9164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bb882e4
Remove permission definitions, rewrite makePermissionDecoder tests to…
jeffsmale90 Jun 15, 2026
164df42
Enforcer addresses passed to makePermissionDecoder should be case ins…
jeffsmale90 Jun 15, 2026
aa79559
Make decodePermission tests more focussed, and unit test like
jeffsmale90 Jun 16, 2026
6fc2c63
Add integration tests for all supported permission types
jeffsmale90 Jun 16, 2026
9e4f620
Remove types duplicated in @metamask/7715-permission-types
jeffsmale90 Jun 18, 2026
7055b57
Upgrade @metamask/7715-permission-types to ^0.8.0
jeffsmale90 Jul 14, 2026
63657c3
Upgrade @metamask/7715-permission-types to ^1.0.0
jeffsmale90 Jul 21, 2026
7cbbc65
Add changelog entry
jeffsmale90 Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/gator-permissions-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

@mj-kiwi mj-kiwi Jul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion — the Unreleased entries currently just say "Changed" for switching to package decoders / bumping the dependency, but don't mention that erc20-token-revocation support seems to have been dropped along the way (see the comment on types.ts). If that drop is intentional, might be worth calling it out explicitly (possibly with a BREAKING: prefix per our changelog convention), so consumers relying on that permission type aren't caught off guard after upgrading.

- Bump `@metamask/7715-permission-types` from `^0.7.1` to `^1.0.0` ([#9164](https://github.com/MetaMask/core/pull/9164))
- Use permission decoders from `@metamask/7715-permission-types`
- **BREAKING:** Drop support for `erc20-token-revocation` permission type

## [4.2.3]

### Changed
Expand Down
1 change: 0 additions & 1 deletion packages/gator-permissions-controller/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const gatorPermissionsController = new GatorPermissionsController({
'native-token-periodic',

@mj-kiwi mj-kiwi Jul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor doc nit — the example supportedPermissionTypes array dropped erc20-token-revocation but doesn't seem to have added token-approval-revocation in its place, even though that type still looks supported. Might just need one line added back so the example stays accurate.

@jeffsmale90 jeffsmale90 Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this example needs to include all implemented permission types - this is showing how the controller may be instantiated with a list of permission types that should be supported.

This list can be incomplete - it's actually highlighting the capability to restrict supported permissions, but also we probably don't want to update this every time we add permission types to the dependency.

'erc20-token-stream',
'erc20-token-periodic',
'erc20-token-revocation',
],
// Optional: override the default gator permissions provider Snap id
// gatorPermissionsProviderSnapId: 'npm:@metamask/gator-permissions-snap',
Expand Down
2 changes: 1 addition & 1 deletion packages/gator-permissions-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch"
},
"dependencies": {
"@metamask/7715-permission-types": "^0.7.1",
"@metamask/7715-permission-types": "^1.0.0",
"@metamask/abi-utils": "^2.0.3",
"@metamask/base-controller": "^9.1.0",
"@metamask/delegation-core": "^2.2.1",
Expand Down
Loading