Skip to content

feat(INFRA-2932): add retry to yarn commands #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bsgrigorov wants to merge 1 commit into from
Closed

feat(INFRA-2932): add retry to yarn commands #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/actions/checkout-and-setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,16 @@ runs:
cache: ${{ ( inputs.is-high-risk-environment != 'true' && steps.download-node-modules.outputs.cache-hit != 'true' ) && 'yarn' || '' }}

# If the node_modules cache was not found (or it's a high-risk environment), run the yarn install
- name: Install dependencies
- name: Install dependencies with retry
if: ${{ steps.download-node-modules.outputs.cache-hit != 'true'}}
run: yarn --immutable
shell: bash
uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 #v3.0.2
Copy link
Copy Markdown
Member

@Mrtenz Mrtenz Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an action for this: MetaMask/action-retry-command. This version of checkout-and-setup is also replaced by MetaMask/action-checkout-and-setup.

Copy link
Copy Markdown
Contributor Author

@bsgrigorov bsgrigorov Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have the nick-fields retry white listed

Copy link
Copy Markdown
Contributor Author

@bsgrigorov bsgrigorov Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah checkout-and-setup doesn't seem to be used

with:
max_attempts: 2
timeout_minutes: 15
retry_wait_seconds: 30
retry_on: error
command: yarn --immutable
shell: bash

# For the 'prep-deps' job, save the node_modules cache
- name: Cache workspace
Expand Down
15 changes: 11 additions & 4 deletions .github/workflows/changelog-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,18 @@ jobs:
cache-dependency-path: ./github-tools/yarn.lock
cache: yarn

- name: Install dependencies
- name: Install dependencies with retry
if: ${{ steps.label-check.outputs.skip_check != 'true' }}
run: yarn --immutable
shell: bash
working-directory: ./github-tools
uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 #v3.0.2
with:
max_attempts: 2
timeout_minutes: 15
retry_wait_seconds: 30
retry_on: error
shell: bash
command: |
cd ./github-tools
yarn --immutable

- name: Check Changelog
if: ${{ steps.label-check.outputs.skip_check != 'true' }}
Expand Down
13 changes: 10 additions & 3 deletions .github/workflows/flaky-test-report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,16 @@ jobs:
run: corepack enable
working-directory: ./github-tools

- name: Install dependencies
working-directory: ./github-tools
run: yarn --immutable
- name: Install dependencies with retry
uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 #v3.0.2
with:
max_attempts: 2
timeout_minutes: 15
retry_wait_seconds: 30
retry_on: error
command: |
cd ./github-tools
yarn --immutable

- name: Run flaky test report script
env:
Expand Down
13 changes: 10 additions & 3 deletions .github/workflows/post-merge-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,16 @@ jobs:
run: corepack enable
working-directory: ./github-tools

- name: Install dependencies
working-directory: ./github-tools
run: yarn --immutable
- name: Install dependencies with retry
uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 #v3.0.2
with:
max_attempts: 2
timeout_minutes: 15
retry_wait_seconds: 30
retry_on: error
command: |
cd ./github-tools
yarn --immutable

- name: Run post-merge-validation script
working-directory: ./github-tools
Expand Down
15 changes: 11 additions & 4 deletions .github/workflows/publish-slack-release-testing-status.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,17 @@ jobs:
shell: bash
working-directory: ./github-tools

- name: Install dependencies
run: yarn --immutable
shell: bash
working-directory: ./github-tools
- name: Install dependencies with retry
uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 #v3.0.2
with:
max_attempts: 2
timeout_minutes: 15
retry_wait_seconds: 30
retry_on: error
shell: bash
command: |
cd ./github-tools
yarn --immutable

# Step 4: Run Script
- name: Publish Slack Release Testing Status
Expand Down
Loading