fix: Bump Xcode 16.2 to 16.3 to fix swift module compilation issue#135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to use Xcode 16.3 to fix a swift modules compilation issue as described here - mrousavy/nitro#422 (comment). We encountered the problem when introducing NitroModules on the mobile client app.
Here's a successful run using the latest commit that bumps Xcode 16.3 - https://github.com/MetaMask/metamask-mobile/actions/runs/18233074525/job/51920895988?pr=20778
Note
Updates
.github/actions/setup-e2e-env/action.ymlto use Xcode 16.3 (default and example) for iOS E2E setup.Written by Cursor Bugbot for commit 7f4144d. This will update automatically on new commits. Configure here.