chore: INFRA-3180: Update team json file for commits.csv during create release pr#180
Merged
Merged
Conversation
| // Step 4: Return the team name or 'Unknown' if not found | ||
| return team || 'Unknown'; | ||
| // Return 'Unknown' if author not found in any team | ||
| return 'Unknown'; |
Contributor
There was a problem hiding this comment.
Could we return undefined here, then update filterCommitsByTeam function, to handle undefined responses, with such a condition:
const team = await getTeam(repository, prMatch) || "none";
It doesn't really change anything but it seems clearer to me.
Contributor
Author
There was a problem hiding this comment.
Good idea, updated
gauthierpetetin
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://consensyssoftware.atlassian.net/browse/INFRA-3180
Fix bug discussed here https://consensys.slack.com/archives/C09B64PEHAQ/p1764576026224679.
Update create-release-pr workflow to use new topology.json) instead of old teams.json file which no longer exists to create commits.csv.
Note
Replace teams.json with topology.json for team resolution and update logic to detect members/roles with fallback to 'none'.
/.github/scripts/generate-rc-commits.mjsto usetopology.jsoninstead ofteams.jsonfor team lookup.membersand roles (pm,em,tl); returnundefinedwhen not found and group such commits undernone.Written by Cursor Bugbot for commit d135939. This will update automatically on new commits. Configure here.