chore(changelog-check): exclude private packages from changelog check#68
Merged
Conversation
4c6c1e1 to
67434c1
Compare
67434c1 to
b74ab88
Compare
rekmarks
reviewed
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for excluding private packages from the changelog check workflow. Private packages in a monorepo typically don't require public changelog entries since they are not published to npm.
Changes
isPrivatePackagefunction to detect private packages by checking theprivatefield in package.jsongetChangedPackagesto skip private packages regardless of which files were changedTesting Steps
Using Core monorepo:
phishing-controllerpackage private by adding"private": trueto its package.jsonpackages/phishing-controller/src/PhishingController.ts:Test with current main version (should fail):
Test with new version (should pass):
Expected Results: