Build testing

[jake-perkins]

No description provided.

[cursor]

Bug: Redundant Secret Name Input

The secret-name input is defined as required but is never used. The action instead determines the secret name based on the environment input, making the secret-name input redundant and confusing.

.github/actions/configure-keystore/action.yml#L10-L13

github-tools/.github/actions/configure-keystore/action.yml

Lines 10 to 13 in 6a7e3cd

	required: true
	secret-name:
	description: "The name of the secret in AWS Secrets Manager"
	required: true

Fix in Cursor • Fix in Web

---

Bug: Shell Parsing Error and Missing Expression Syntax

The for key in $keys loop in the "Fetch secret and export as environment variables" step is vulnerable to shell word splitting, which will incorrectly parse JSON keys containing spaces or special characters. Additionally, the if condition for the "Configure Android Keystore" step (if: inputs.platform == 'android') is missing the required ${{ }} expression syntax.

.github/actions/configure-keystore/action.yml#L59-L69

github-tools/.github/actions/configure-keystore/action.yml

Lines 59 to 69 in 6a7e3cd

	keys=$(echo "$secret_json" | jq -r 'keys[]')
	for key in $keys; do
	value=$(echo "$secret_json" | jq -r --arg k "$key" '.[$k]')
	echo "::add-mask::$value"
	echo "$key=$(printf '%s' "$value")" >> "$GITHUB_ENV"
	echo "✅ Set secret for key: $key"
	done
	- name: Configure Android Keystore
	if: inputs.platform == 'android'

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎