P256,P384,P512: reject incorrect ECDSA curve when reading keys#42
Merged
Conversation
dovydas55
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Tightens cryptographic key parsing in security-sensitive code; valid keys on the correct curve are unchanged, but previously accepted wrong-curve imports will now error.
Overview
P-256, P-384, and P-521 key loaders now reject keys on the wrong curve when importing X.509 DER public keys and PKCS#8 DER private keys. Each package checks
ecdsaPub.Curve/ecdsaPriv.Curveagainst its expectedellipticcurve and returns a clear error instead of accepting another NIST curve’s material.Tests add
TestRejectForeignCurveX509AndPKCS8in each package, generating keys from sibling curves and assertingPublicKeyFromX509DERandPrivateKeyFromPKCS8DERfail.Reviewed by Cursor Bugbot for commit 86d95b9. Bugbot is set up for automated code reviews on this repo. Configure here.