rsa: add missing exponent too small check#44
Merged
Conversation
dovydas55
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Tightens input validation on RSA key import with new tests; only rejects previously accepted invalid exponents like 1.
Overview
PublicKeyFromNEnow rejects public exponents < 2 (e.g. exponent 1) withexponent too small, in addition to existing positive/odd/int64 checks. That path is used when building keys from raw N/E bytes and fromPrivateKeyFromNEDPQ.key_test.goadds round-trip tests for PKCS#1 DER, N/E, and N/E/D/P/Q reconstruction, plusTestRejectWeirdPublicKeyInputstable tests that assertPublicKeyFromNEerrors on bad moduli (empty, short, oversized, even) and bad exponents (empty, one, even, too large for int64).Reviewed by Cursor Bugbot for commit ed857fe. Bugbot is set up for automated code reviews on this repo. Configure here.