chore(master): rename master branch into stable cp-13.3.0#35576
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [4b90463]
UI Startup Metrics (1205 ± 50 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 234 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1415 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 266 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 77 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1630 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1393 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1393 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 115 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1369 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 293 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 353ms | Sum of p95 exceeds: 540.8ms Sum of all benchmark exceeds: 893.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
HowardBraham
reviewed
Sep 2, 2025
Comment on lines
+1352
to
+1356
| - This build was needed to fix release publishing on our stable branch. It also includes the addition of the missing v12.2.0 changelog. Functionality and code is equivalent to v12.2.0. | ||
|
|
||
| ## [12.2.1] | ||
| ### Fixed | ||
| - This build was needed to fix release publishing on our master branch. It also includes the addition of the missing v12.2.0 changelog. Functionality and code is equivalent to v12.2.0. | ||
| - This build was needed to fix release publishing on our stable branch. It also includes the addition of the missing v12.2.0 changelog. Functionality and code is equivalent to v12.2.0. |
Contributor
There was a problem hiding this comment.
These changes raise interesting questions. It wouldn't actually change the real published changelog.
I would either change it here as well https://github.com/MetaMask/metamask-extension/releases/tag/v12.2.2 or change it nowhere
Contributor
Author
There was a problem hiding this comment.
Makes sense, I reverted the changlog changes in this commit: 4d68a56
gauthierpetetin
commented
Sep 3, 2025
| jobs: | ||
| get-release-timelines: | ||
| uses: metamask/github-tools/.github/workflows/get-release-timelines.yml@13b73c8c7dd15f38bacc1bb95401fe11914c6629 | ||
| uses: metamask/github-tools/.github/workflows/get-release-timelines.yml@b39d2cf87af5e31c4a85a83221e3a40b79edf06c |
Contributor
Author
There was a problem hiding this comment.
This change is to include branch renaming on github-tools repo, included in this PR: MetaMask/github-tools#115
HowardBraham
approved these changes
Sep 3, 2025
gauthierpetetin
changed the title
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [4d68a56]
UI Startup Metrics (1229 ± 72 ms)
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1374 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1206 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1196 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 21 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 953 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 41 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 285 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 197 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 105 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 260 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 286ms | Sum of p95 exceeds: 565.8ms Sum of all benchmark exceeds: 851.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-13.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to remove all references to
masterbranch right after we've renamedmasterbranch intostable.Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist