chore: bump @metamask/sdk from 0.30.1 to 0.34.0#432
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution MetaMask internal reviewing guidelines:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
SDK 0.30.1 shipped with @metamask/sdk-communication-layer 0.30.0 which did not include `anonId` in OriginatorInfo. This meant the wallet-side SDK Legacy RPC Request analytics events (gated on `connection.originatorInfo?.anonId`) would silently never fire. SDK 0.34.0 pulls in communication-layer 0.33.1 which generates and persists an anonymous session ID (`anonId`) automatically, enabling wallet-side analytics correlation.
cd2a367 to
6996870
Compare
Summary
@metamask/sdkfrom0.30.1to0.34.0, which pulls in@metamask/sdk-communication-layer0.33.1(was0.30.0).anonIdinOriginatorInfo, so wallet-side analytics events gated onconnection.originatorInfo?.anonId(e.g.SDK Legacy RPC Request Received/Approved/Rejected,Remote Connection Request Received) would silently never fire.anonId) inlocalStorage, enabling wallet-side analytics correlation for SDKv1 connections.Context
Related mobile PRs that depend on
anonIdbeing present:remote_session_idfrom dapp to wallet in SDKConnectV2 connection metadata for cross-side analytics correlation metamask-mobile#28470 (remote_session_id for MWP)Test plan
anonIdappears in theOriginatorInfopayload (check Metro console for[MM SDK Analytics]log lines)SDK Legacy RPC Request Receivedevents fire for tracked RPC methods (personal_sign,eth_sendTransaction, etc.)Note
Medium Risk
Upgrading
@metamask/sdkmay change wallet connection/communication behavior and analytics/session identifiers for the test dapp, which could affect e2e flows despite being a dependency-only change.Overview
Updates the test dapp to use
@metamask/sdk@0.34.0(from0.30.1), pulling in newer SDK communication-layer dependencies viayarn.lock.Reviewed by Cursor Bugbot for commit 6996870. Bugbot is set up for automated code reviews on this repo. Configure here.