Skip to content

Fix #692: redact PII in auth logs by hashing email identifiers #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omega58754 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #692: redact PII in auth logs by hashing email identifiers #823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/auth/auth.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ type JwtPayload = {
export class AuthService {
private readonly logger = new Logger(AuthService.name);
private readonly issuer = 'PropChain';

private hashEmail(email: string): string {
return createSha256(email).slice(0, 12);
}

private readonly accessTokenTtlSeconds: number;
private readonly refreshTokenTtlSeconds: number;
private readonly jwtSecret: string;
Expand Down Expand Up @@ -201,7 +206,9 @@ export class AuthService {
if (shouldLock) {
const lockoutDuration = 30;
await this.emailService.sendAccountLockedEmail(user.email, lockoutDuration).catch((err) => {
this.logger.error(`Failed to send account locked email to ${user.email}: ${err.message}`);
this.logger.error(
`Failed to send account locked email to user ${user.id} (${this.hashEmail(user.email)}): ${err.message}`,
);
});

throw new UnauthorizedException(
Expand Down Expand Up @@ -329,7 +336,7 @@ export class AuthService {
const tokens = await this.issueTokenPair(user, payload.family, ipAddress, userAgent);

this.logger.log(
`Token rotated for user ${user.id} (${user.email}). Family: ${payload.family}. IP: ${ipAddress}`,
`Token rotated for user ${user.id} (${this.hashEmail(user.email)}). Family: ${payload.family}. IP: ${ipAddress}`,
);

return {
Expand Down Expand Up @@ -426,7 +433,7 @@ export class AuthService {

// Log the logout event
this.logger.log(
`User ${user.sub} (${user.email}) logged out successfully at ${logoutTime.toISOString()}`,
`User ${user.sub} (${this.hashEmail(user.email)}) logged out successfully at ${logoutTime.toISOString()}`,
);

return {
Expand Down Expand Up @@ -476,7 +483,7 @@ export class AuthService {
});

this.logger.log(
`User ${user.sub} (${user.email}) logged out from all devices at ${logoutTime.toISOString()}. Total active blacklisted refresh tokens: ${blacklistedRefreshTokens.length}`,
`User ${user.sub} (${this.hashEmail(user.email)}) logged out from all devices at ${logoutTime.toISOString()}. Total active blacklisted refresh tokens: ${blacklistedRefreshTokens.length}`,
);

return {
Expand Down
Loading