perf(bridge): replace validator signature vecs with bitmap storage#544
Merged
Conversation
|
@AJ0070 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
@nanaf6203-bit Failures are not related to my changes. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes bridge validator signature tracking by replacing per-request
Vec<AccountId>signer storage with a 256-bit bitmap representation.Changes
[u8; 32]get_signature_bitmap(request_id)for raw bitmap queriesget_signer_list(request_id)for human-readable signer reconstructionVec<AccountId>-based requestscontracts/bridge/src/tests.rstests.rsis compiled and executed in the bridge crateBackward Compatibility
Existing bridge requests stored with the legacy signature format remain readable.
New requests are stored using the bitmap representation.
Test Coverage
Added and/or validated tests for:
Benchmark Note
The included test benchmark shows the bitmap encoding is smaller than the legacy
Vec<AccountId>encoding for 24 validator signatures, which is the expected storage/gas improvement target for larger validator sets.fixes #514