Replace RocksDB upgrade ledger tar check with sync test#18686
Merged
glyh merged 2 commits intocompatiblefrom Apr 17, 2026
Merged
Replace RocksDB upgrade ledger tar check with sync test#18686glyh merged 2 commits intocompatiblefrom
glyh merged 2 commits intocompatiblefrom
Conversation
glyh
force-pushed
the
lyh/rocksdb-upgrade-test
branch
from
aaf4900 to
bf9fa18
Compare
glyh
force-pushed
the
lyh/rocksdb-upgrade-test
branch
from
bf9fa18 to
c15ade3
Compare
Member
Author
|
!ci-single-me ConnectToMainnet |
glyh
force-pushed
the
lyh/rocksdb-upgrade-test
branch
from
c15ade3 to
a3bb2d6
Compare
Member
Author
|
!ci-single-me ConnectToMainnet |
SanabriaRusso
approved these changes
Apr 17, 2026
Member
Author
|
!ci-build-me |
Member
|
!ci-bypass-changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old RocksDB ledger upgrade check is removed, as it's failing too frequently due to rate limit on s3 bucket.
It's replaced with a more comprehensive test where we actually upgrade the daemon to current from stable and try to sync to the network with a legacy on disk database.