Repository navigation
Limit the model provider exemption to its port on public addresses - #893
Merged
Merged
Conversation
SaladDay
force-pushed
the
narrow-model-endpoint-egress
branch
from
October 27, 2026 19:06
835935c to
4c4ebaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An application sets the model provider
base_url, and Core allowed every port of every address that host resolves to, private ones included. An application could therefore reach any intranet host from a sandbox, even withnetwork.access = "disabled".Egress.Endpointsentries are nowhost:portand mean that TCP port on public addresses only. Core derives them from the modelbase_url(443 for https, 80 for http by default); loopback hosts are skipped.PrivateDomains, under every policy. A private IP-literal endpoint is not reachable.PrivateDomainsnames; an Endpoint becomes a tcp+port domain (or public IP) allow afterdeny private. Core andPrivateDomainsnames resolve concurrently under one 5 s deadline instead of up to 5 s each in sequence.allow_outonly works on ports 80 and 443 (verified live), so the Core host and Endpoints on other ports also get their public IPv4 /32 addresses.allocationEgressfails with the lookup error when the Session is not found, instead of deriving egress from the full cap.Tests: egress derivation (public, cap-listed private under
disabled, private IP literal, loopback), microsandbox rule order, E2Ballow_outfor a non-443 Endpoint, and the fail-closed lookup.Need help on this PR? Tag
@codesmith-botwith what you need.