Repository navigation
Disable strict hostname enforcement only on microsandbox create - #896
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#894 put
DisableStrictinto the network config shared by create and restore. The pinned Go SDK rejects any restoreNetworkConfigfield other than the rules and default actions, so every microsandbox checkpoint restore fails since #894 (resume stays unconfirmed; follow-ups expire with 409environment_input_expired).Create sets
DisableStrict; restore sends only the policy. The README sentence about strict mode was stale and now says this.Checks:
GOWORK=off go vet .and the network tests in the adapter module.Need help on this PR? Tag
@codesmith-botwith what you need.