Repository navigation
Pin public addresses of allowed names on microsandbox restore - #897
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsandbox restore cannot turn strict hostname enforcement off (the SDK takes only the policy there), so after a resume every domain allow stopped passing HTTPS. On mx a
restrictedSession's follow-up Turn after suspend failed withconnection_failedbecause the model provider is a domain allow.Until restore can set it (upstream superradcompany/microsandbox#1954), a restored sandbox that is not public also allows the public addresses each name of
Domains,PrivateDomainsandEndpointsresolves to at restore, ahead of every domain allow (a domain allow that matches first would refuse the address under strict enforcement), on the same port (Endpoint) or port-less (names). Create keepsDisableStrict, now set inegressNetworknext to the reason. Limits after a resume, for every sandbox without public internet includingenabledunder a cap without it (environments.md, linked from the cap table and the compatibility notes, EN + zh): except over plain HTTP, a later DNS change is missed, and other sites on those addresses are reachable.Round-3 review doc fixes in the same PR:
disabledmoves into thedisableddefinition and the compatibility notes.Checks:
GOWORK=off go vet .and the adapter network tests (newTestRestorePinsPublicAddresses). mx (helper from this branch): restricted example.com and disabled Sessions suspend and resume (node log: suspend and resume with no error); after resume the Turns complete, example.com 200 under restricted, example.org refused, disabled refuses example.com, unlisted intranet and metadata closed.Need help on this PR? Tag
@codesmith-botwith what you need.