GEOPY-2739: Accept BaseUIJson in the start of driver#190
GEOPY-2739: Accept BaseUIJson in the start of driver#190domfournier merged 28 commits intofeature/uijsonfrom
Conversation
# Conflicts: # geoapps_utils/base.py
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates geoapps-utils to work with geoh5py.ui_json.UIJson as the primary ui.json representation (instead of InputFile/BaseUIJson), including allowing drivers to start from a UIJson instance and updating related templates and tests.
Changes:
- Switch driver startup and UIJsonGroup execution flow to use
UIJsonobjects directly. - Refactor
Optionsto derive/serialize UIJson via a default template (base.ui.json) and adjust tests accordingly. - Update the base ui.json asset schema for
out_groupand pingeoh5pyto a GEOPY-2739 revision.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
geoapps_utils/base.py |
Refactors Driver.start and Options to operate around UIJson, adds deprecation path for InputFile, and updates serialization/out_group saving. |
geoapps_utils/run.py |
Updates run_uijson_group and workspace/ui.json copy helpers to use UIJson.read/from_dict/write. |
geoapps_utils-assets/uijson/base.ui.json |
Updates the base template to represent out_group as a structured group parameter object. |
tests/uijson_run_test.py |
Updates test setup to build and write a UIJson file directly and adjusts expected filenames. |
tests/driver_test.py |
Aligns tests with new UIJson-based serialization behavior and updated exception types. |
tests/dataclass_test.py |
Loosens flatten equality assertions to avoid direct geoh5 comparisons and updates UIJson writing callsites. |
pyproject.toml |
Pins geoh5py dependency to rev = "GEOPY-2739". |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/uijson #190 +/- ##
==================================================
+ Coverage 85.12% 85.68% +0.55%
==================================================
Files 19 18 -1
Lines 1163 908 -255
Branches 151 114 -37
==================================================
- Hits 990 778 -212
+ Misses 134 95 -39
+ Partials 39 35 -4
🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
MatthieuCMira
left a comment
There was a problem hiding this comment.
failueres with scigeoh5.
The solution is to open everything in the same workspace.
MatthieuCMira
left a comment
There was a problem hiding this comment.
It's getting good.
Few comments, mostly questions


GEOPY-2739 - Accept BaseUIJson in the start of driver