GEOPY-2794: Change reference of Plate from center-center to top-center#193
GEOPY-2794: Change reference of Plate from center-center to top-center#193domfournier merged 8 commits intodevelopfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #193 +/- ##
===========================================
+ Coverage 84.86% 85.52% +0.66%
===========================================
Files 19 19
Lines 1163 1161 -2
Branches 151 151
===========================================
+ Hits 987 993 +6
+ Misses 136 129 -7
+ Partials 40 39 -1
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the plate modelling utilities to use a consistent unrotated bounding-box definition (dip extent anchored at the origin) and refactors geometry/masking to share that logic, with corresponding test updates.
Changes:
- Added a
bounding_boxhelper and refactoredPlate.verticesandinside_plateto use it. - Adjusted
inside_plate/make_platetest expectations to match the new origin/dip-extent convention. - Made
PlateModel.easting/northing/elevationdefault to0.0and expanded docstrings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
geoapps_utils/modelling/plates.py |
Introduces bounding_box, refactors geometry/masking around it, and changes PlateModel defaults/documentation. |
tests/plates_test.py |
Adds coverage for bounding_box and updates masks/expectations for the new bounding-box convention. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MatthieuCMira
left a comment
There was a problem hiding this comment.
seems good to me.
I docstring missing.
Can you explain me why you need defualt values if in the model_validator you check for the values to be there?
GEOPY-2794 - Change reference of Plate from center-center to top-center