GEOPY-2793: Add conversion from/to maxwell plate with test#194
Merged
domfournier merged 13 commits intodevelopfrom Apr 14, 2026
Merged
GEOPY-2793: Add conversion from/to maxwell plate with test#194domfournier merged 13 commits intodevelopfrom
domfournier merged 13 commits intodevelopfrom
Conversation
github-actions
bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds interoperability between geoapps_utils.modelling.plates.Plate/PlateModel and geoh5py’s MaxwellPlate geometry, along with an integration test to validate round-tripping and warning behavior.
Changes:
- Added
PlateModel <-> PlateGeometryconversion helpers (including a warning when rotation/plunge is present). - Added
Plate <-> MaxwellPlateconversion methods. - Added an integration test covering
to_maxwell_plate/from_maxwell_plateand warning emission.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
geoapps_utils/modelling/plates.py |
Introduces conversion helpers between internal plate parameters and geoh5py Maxwell plate geometry/object. |
tests/plates_test.py |
Adds a round-trip integration test using a workspace and validating a warning when rotation is set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #194 +/- ##
===========================================
+ Coverage 85.52% 85.59% +0.06%
===========================================
Files 19 19
Lines 1161 1180 +19
Branches 151 153 +2
===========================================
+ Hits 993 1010 +17
Misses 129 129
- Partials 39 41 +2
🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ke length mixed up. Should improve geoh5py docs.
domfournier
reviewed
Apr 13, 2026
domfournier
reviewed
Apr 13, 2026
Co-authored-by: domfournier <dominiquef@mirageoscience.com>
Co-authored-by: domfournier <dominiquef@mirageoscience.com>
for more information, see https://pre-commit.ci
# Conflicts: # geoapps_utils/modelling/plates.py # tests/plates_test.py
domfournier
approved these changes
Apr 14, 2026
domfournier
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2793 - Add conversion between Plate model from and to Maxwell plates