Skip to content

GEOPY-2794: Change reference of Plate from center-center to top-center#374

Merged
domfournier merged 14 commits intodevelopfrom
GEOPY-2794
Apr 14, 2026
Merged

GEOPY-2794: Change reference of Plate from center-center to top-center#374
domfournier merged 14 commits intodevelopfrom
GEOPY-2794

Conversation

@benk-mira
Copy link
Copy Markdown
Contributor

@benk-mira benk-mira commented Apr 9, 2026

GEOPY-2794 - Change reference of Plate from center-center to top-center

Copilot AI review requested due to automatic review settings April 9, 2026 22:16
@github-actions github-actions bot changed the title Geopy 2794 GEOPY-2794: Change reference of Plate from center-center to top-center Apr 9, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the plate simulation configuration to interpret the plate “elevation” input as a depth below topography, simplifying/removing the prior “relative locations / reference surface” workflow and aligning tests + UI with the new depth-based behaviour.

Changes:

  • Reworked PlateOptions.center() to compute plate Z from topography at the survey centre (depth-based placement).
  • Removed relative_locations, reference_surface, and reference_type from the plate simulation UI + tests.
  • Updated synthetic defaults and multiple tests to match the new depth convention.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
tests/plate_simulation/runtest/sweep_test.py Updates sweep test setup to use depth-style elevation and removes deprecated options.
tests/plate_simulation/runtest/gravity_test.py Adjusts plate geometry inputs for new depth semantics and removes deprecated reference.
tests/plate_simulation/runtest/driver_test.py Removes deprecated input fields; still contains an inconsistent negative “depth” test value.
tests/plate_simulation/models/plates_test.py Makes assertions more robust with np.isclose; tweaks naming and replication expectations.
tests/plate_simulation/models/params_test.py Adds coverage for new centre/depth logic; removes tests for deleted reference/relative behaviour.
simpeg_drivers/utils/synthetics/options.py Updates default plate model parameters (dip/direction and elevation default).
simpeg_drivers/plate_simulation/uijson.py Removes the old PlateSimulationUIJson Python schema file.
simpeg_drivers/plate_simulation/models/options.py Implements new centre calculation using topography draping; removes old relative/reference logic.
simpeg_drivers/plate_simulation/models/events.py Broadens Anomaly typing to accept Plate bodies.
simpeg_drivers/plate_simulation/driver.py Updates plate instantiation to use the new center() signature and exposes topography earlier.
simpeg_drivers-assets/uijson/plate_simulation.ui.json Removes relative/reference UI fields and relabels elevation as depth.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@MatthieuCMira MatthieuCMira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are not passing....

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (bca4d6c) to head (eb70bf7).
⚠️ Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #374      +/-   ##
===========================================
+ Coverage    89.57%   90.05%   +0.48%     
===========================================
  Files          128      127       -1     
  Lines         6409     6368      -41     
  Branches       797      795       -2     
===========================================
- Hits          5741     5735       -6     
+ Misses         462      428      -34     
+ Partials       206      205       -1     
Files with missing lines Coverage Δ
simpeg_drivers/options.py 95.13% <ø> (-0.02%) ⬇️
simpeg_drivers/plate_simulation/driver.py 92.96% <100.00%> (-0.06%) ⬇️
simpeg_drivers/plate_simulation/models/events.py 100.00% <100.00%> (ø)
simpeg_drivers/plate_simulation/models/options.py 100.00% <100.00%> (+4.00%) ⬆️
simpeg_drivers/utils/synthetics/options.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier domfournier merged commit 13c5823 into develop Apr 14, 2026
19 checks passed
@domfournier domfournier deleted the GEOPY-2794 branch April 14, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants