GEOPY-2794: Change reference of Plate from center-center to top-center#374
Merged
domfournier merged 14 commits intodevelopfrom Apr 14, 2026
Merged
GEOPY-2794: Change reference of Plate from center-center to top-center#374domfournier merged 14 commits intodevelopfrom
domfournier merged 14 commits intodevelopfrom
Conversation
…point method to convert input depth to elevation used by Plate objects
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the plate simulation configuration to interpret the plate “elevation” input as a depth below topography, simplifying/removing the prior “relative locations / reference surface” workflow and aligning tests + UI with the new depth-based behaviour.
Changes:
- Reworked
PlateOptions.center()to compute plate Z from topography at the survey centre (depth-based placement). - Removed
relative_locations,reference_surface, andreference_typefrom the plate simulation UI + tests. - Updated synthetic defaults and multiple tests to match the new depth convention.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/plate_simulation/runtest/sweep_test.py | Updates sweep test setup to use depth-style elevation and removes deprecated options. |
| tests/plate_simulation/runtest/gravity_test.py | Adjusts plate geometry inputs for new depth semantics and removes deprecated reference. |
| tests/plate_simulation/runtest/driver_test.py | Removes deprecated input fields; still contains an inconsistent negative “depth” test value. |
| tests/plate_simulation/models/plates_test.py | Makes assertions more robust with np.isclose; tweaks naming and replication expectations. |
| tests/plate_simulation/models/params_test.py | Adds coverage for new centre/depth logic; removes tests for deleted reference/relative behaviour. |
| simpeg_drivers/utils/synthetics/options.py | Updates default plate model parameters (dip/direction and elevation default). |
| simpeg_drivers/plate_simulation/uijson.py | Removes the old PlateSimulationUIJson Python schema file. |
| simpeg_drivers/plate_simulation/models/options.py | Implements new centre calculation using topography draping; removes old relative/reference logic. |
| simpeg_drivers/plate_simulation/models/events.py | Broadens Anomaly typing to accept Plate bodies. |
| simpeg_drivers/plate_simulation/driver.py | Updates plate instantiation to use the new center() signature and exposes topography earlier. |
| simpeg_drivers-assets/uijson/plate_simulation.ui.json | Removes relative/reference UI fields and relabels elevation as depth. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MatthieuCMira
requested changes
Apr 13, 2026
Contributor
MatthieuCMira
left a comment
There was a problem hiding this comment.
tests are not passing....
…h) is less that the overburden thickness
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #374 +/- ##
===========================================
+ Coverage 89.57% 90.05% +0.48%
===========================================
Files 128 127 -1
Lines 6409 6368 -41
Branches 797 795 -2
===========================================
- Hits 5741 5735 -6
+ Misses 462 428 -34
+ Partials 206 205 -1
🚀 New features to boost your workflow:
|
domfournier
approved these changes
Apr 14, 2026
domfournier
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2794 - Change reference of Plate from center-center to top-center