GEOPY-2795: Update dictionary to choose driver from run_command#376
Merged
domfournier merged 2 commits intodevelopfrom Apr 14, 2026
Merged
GEOPY-2795: Update dictionary to choose driver from run_command#376domfournier merged 2 commits intodevelopfrom
domfournier merged 2 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes dynamic driver resolution for joint inversion drivers by ensuring the expected driver classes are available at the package level and by correcting the DRIVER_MAP entry for “joint surveys”. It also adds a regression test to confirm drivers can be resolved from legacy .ui.json files.
Changes:
- Re-export joint driver classes/options in
simpeg_drivers.joint.*package__init__.pyfiles sodriver_class_from_name()cangetattr()them. - Fix the “joint surveys”
DRIVER_MAPinversion class name toJointSurveysDriver. - Add a test that loads legacy UI JSON files and verifies
from_input_file()resolves a driver class.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/uijson_test.py | Adds a regression test that loads legacy .ui.json files and ensures from_input_file() returns a driver class. |
| simpeg_drivers/joint/joint_surveys/init.py | Re-exports JointSurveysDriver / JointSurveysOptions at the package level. |
| simpeg_drivers/joint/joint_petrophysics/init.py | Re-exports JointPetrophysicsDriver / JointPetrophysicsOptions at the package level. |
| simpeg_drivers/joint/joint_cross_gradient/init.py | Re-exports JointCrossGradientDriver / JointCrossGradientOptions at the package level. |
| simpeg_drivers/init.py | Corrects the DRIVER_MAP inversion class string for “joint surveys”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #376 +/- ##
========================================
Coverage 89.56% 89.57%
========================================
Files 125 128 +3
Lines 6403 6409 +6
Branches 797 797
========================================
+ Hits 5735 5741 +6
Misses 462 462
Partials 206 206
🚀 New features to boost your workflow:
|
benk-mira
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2795 - Update dictionary to choose driver from run_command