Skip to content

GEOPY-2795: Update dictionary to choose driver from run_command#376

Merged
domfournier merged 2 commits intodevelopfrom
GEOPY-2795
Apr 14, 2026
Merged

GEOPY-2795: Update dictionary to choose driver from run_command#376
domfournier merged 2 commits intodevelopfrom
GEOPY-2795

Conversation

@domfournier
Copy link
Copy Markdown
Collaborator

@domfournier domfournier commented Apr 13, 2026

GEOPY-2795 - Update dictionary to choose driver from run_command

Copilot AI review requested due to automatic review settings April 13, 2026 21:51
@github-actions github-actions bot changed the title GEOPY-2795 GEOPY-2795: Update dictionary to choose driver from run_command Apr 13, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes dynamic driver resolution for joint inversion drivers by ensuring the expected driver classes are available at the package level and by correcting the DRIVER_MAP entry for “joint surveys”. It also adds a regression test to confirm drivers can be resolved from legacy .ui.json files.

Changes:

  • Re-export joint driver classes/options in simpeg_drivers.joint.* package __init__.py files so driver_class_from_name() can getattr() them.
  • Fix the “joint surveys” DRIVER_MAP inversion class name to JointSurveysDriver.
  • Add a test that loads legacy UI JSON files and verifies from_input_file() resolves a driver class.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/uijson_test.py Adds a regression test that loads legacy .ui.json files and ensures from_input_file() returns a driver class.
simpeg_drivers/joint/joint_surveys/init.py Re-exports JointSurveysDriver / JointSurveysOptions at the package level.
simpeg_drivers/joint/joint_petrophysics/init.py Re-exports JointPetrophysicsDriver / JointPetrophysicsOptions at the package level.
simpeg_drivers/joint/joint_cross_gradient/init.py Re-exports JointCrossGradientDriver / JointCrossGradientOptions at the package level.
simpeg_drivers/init.py Corrects the DRIVER_MAP inversion class string for “joint surveys”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.57%. Comparing base (155e6f0) to head (a19d09a).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #376   +/-   ##
========================================
  Coverage    89.56%   89.57%           
========================================
  Files          125      128    +3     
  Lines         6403     6409    +6     
  Branches       797      797           
========================================
+ Hits          5735     5741    +6     
  Misses         462      462           
  Partials       206      206           
Files with missing lines Coverage Δ
simpeg_drivers/__init__.py 88.88% <ø> (ø)
...peg_drivers/joint/joint_cross_gradient/__init__.py 100.00% <100.00%> (ø)
...impeg_drivers/joint/joint_petrophysics/__init__.py 100.00% <100.00%> (ø)
simpeg_drivers/joint/joint_surveys/__init__.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier domfournier merged commit bca4d6c into develop Apr 14, 2026
23 checks passed
@domfournier domfournier deleted the GEOPY-2795 branch April 14, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants