Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR appears to improve dtype consistency for the magnetic PDE simulation (supporting solver_dtype), fix a GeoH5 save edge case, adjust vector-inversion switching logic, and add a Dask-based getJtJdiag implementation for the magnetic PDE simulation.
Changes:
- Cast magnetic PDE RHS / intermediate vectors to
solver_dtypebefore solver application. - Fix property-group saving when no matching children exist.
- Add Dask
getJtJdiagpatch forSimulation3DDifferentialand import it fromsimpeg.dask.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
simpeg/potential_fields/magnetics/simulation.py |
Cast RHS and certain solver inputs to solver_dtype. |
simpeg/maps/_base.py |
Initialize Wires._nP earlier to support building Projection wires. |
simpeg/directives/_vector_models.py |
Change inversion_type default and gate coordinate switching on it. |
simpeg/directives/_save_geoh5.py |
Avoid IndexError when children is empty. |
simpeg/dask/potential_fields/magnetics/simulation_pde.py |
New Dask/parallel getJtJdiag implementation for PDE magnetics (monkey patch). |
simpeg/dask/__init__.py |
Ensure the new Dask PDE patch module is imported when Dask is available. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
benk-mira
previously approved these changes
Apr 13, 2026
benk-mira
left a comment
There was a problem hiding this comment.
All good for me, but check the copilot suggestions and apply as necessary
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.