Skip to content

GEOPY-2799#137

Merged
domfournier merged 8 commits intodevelopfrom
GEOPY-2799
Apr 14, 2026
Merged

GEOPY-2799#137
domfournier merged 8 commits intodevelopfrom
GEOPY-2799

Conversation

@domfournier
Copy link
Copy Markdown

No description provided.

Copilot AI review requested due to automatic review settings April 13, 2026 20:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR appears to improve dtype consistency for the magnetic PDE simulation (supporting solver_dtype), fix a GeoH5 save edge case, adjust vector-inversion switching logic, and add a Dask-based getJtJdiag implementation for the magnetic PDE simulation.

Changes:

  • Cast magnetic PDE RHS / intermediate vectors to solver_dtype before solver application.
  • Fix property-group saving when no matching children exist.
  • Add Dask getJtJdiag patch for Simulation3DDifferential and import it from simpeg.dask.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
simpeg/potential_fields/magnetics/simulation.py Cast RHS and certain solver inputs to solver_dtype.
simpeg/maps/_base.py Initialize Wires._nP earlier to support building Projection wires.
simpeg/directives/_vector_models.py Change inversion_type default and gate coordinate switching on it.
simpeg/directives/_save_geoh5.py Avoid IndexError when children is empty.
simpeg/dask/potential_fields/magnetics/simulation_pde.py New Dask/parallel getJtJdiag implementation for PDE magnetics (monkey patch).
simpeg/dask/__init__.py Ensure the new Dask PDE patch module is imported when Dask is available.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

benk-mira
benk-mira previously approved these changes Apr 13, 2026
Copy link
Copy Markdown

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me, but check the copilot suggestions and apply as necessary

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@domfournier domfournier merged commit 3430f93 into develop Apr 14, 2026
9 checks passed
@domfournier domfournier deleted the GEOPY-2799 branch April 14, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants