Skip to content

veil#344

Open
Eyanus wants to merge 14 commits into
Miracle656:mainfrom
Eyanus:veil
Open

veil#344
Eyanus wants to merge 14 commits into
Miracle656:mainfrom
Eyanus:veil

Conversation

@Eyanus

@Eyanus Eyanus commented Jun 25, 2026

Copy link
Copy Markdown

Summary

Adds Angular SDK support for Veil with VeilService, VeilModule, and standalone-compatible provideVeil(...). Also adds an Angular example app demonstrating dependency injection usage and fixes SDK package exports so Angular consumers can resolve the built SDK entrypoints correctly.

Related issue

Closes #310

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Docs
  • Tests
  • CI / tooling

Component

  • Wallet frontend
  • SDK
  • Contracts
  • Agent

Checklist

  • I have read CONTRIBUTING.md
  • cargo test passes (contracts)
  • npm run typecheck passes (wallet / sdk / agent)
  • npm run build passes (wallet / agent)
  • I added or updated tests where relevant
  • I updated docs / README where relevant

Screenshots / test output

cd sdk
npm run build

passes

cd examples/angular
npm run build

blocked in Codex sandbox by parent-directory read restrictions

Verified Angular build successfully through mapped project path:

ng build

passes

@Eyanus Eyanus requested a review from Miracle656 as a code owner June 25, 2026 10:30
@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

@Eyanus is attempting to deploy a commit to the miracle656's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jun 25, 2026

Copy link
Copy Markdown

@Eyanus Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Miracle656 Miracle656 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the Angular adapter — the core (sdk/angular/*, examples/angular source, provideVeil/VeilModule) looks good and closes #310. A few things need cleaning up before merge:

1. Remove committed build artifacts. The PR commits examples/angular/.angular/cache/ files (angular-compiler.db, angular-compiler.db-lock, .tsbuildinfo). These are local build cache and shouldn't be in git. Please git rm -r --cached examples/angular/.angular and add .angular/ (or examples/*/.angular/) to .gitignore. The .npm-cache/ ignores you added are fine to keep, but they don't cover .angular/cache.

2. Revert the contract test snapshot. contracts/multisig-wallet/test_snapshots/tests/test_multisig_flow.1.json has an unrelated change (a new propose_transaction auth entry). This PR doesn't touch contracts, so that's almost certainly an accidental local regeneration — please git checkout origin/main -- contracts/multisig-wallet/test_snapshots to drop it.

3. Keep the PR scoped to Angular. The sdk/react/src/hooks/useBalance.ts useBalance(token?) change and the react test edits are unrelated to the Angular adapter. The signature improvement is reasonable, but please split it into its own PR so this one stays reviewable.

Once the artifacts and the contract snapshot are reverted and the react changes split out, this is good to merge. 👍

Eyanus added 6 commits June 25, 2026 14:25
Thanks for the feedback. I've addressed the requested changes and pushed the updates to this PR. Please let me know if there's anything else that needs adjustment.
changes made
fixed some errors
@gitguardian

gitguardian Bot commented Jun 26, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - JSON Web Token 60edca7 replace.txt View secret
34267434 Triggered Generic High Entropy Secret 41b60d1 frontend/wallet/lib/tests/backup.test.ts View secret
30459197 Triggered JSON Web Token 3a5295c frontend/website/lib/supabase.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Eyanus Eyanus left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm and let me know if there's anything you'll want me to change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular adapter

2 participants