feat(sdk): Storybook for React components, deployed to GitHub Pages (#357)#362
Open
Ipramking wants to merge 1 commit into
Open
feat(sdk): Storybook for React components, deployed to GitHub Pages (#357)#362Ipramking wants to merge 1 commit into
Ipramking wants to merge 1 commit into
Conversation
Add presentational React components for the SDK hooks and a Storybook that documents them, deployed to GitHub Pages. - sdk/react/src/components: AccountBadge, BalanceCard, SendPaymentForm, TxStatusPill, ConnectButton -- presentational components paired with useAccount / useBalance / useSendPayment / useTransactionStatus and the provider wallet. Exported from invisible-wallet-sdk/react. - Storybook (sdk/react/.storybook) with stories for every component (default, loading, error and other states). - .github/workflows/storybook.yml builds Storybook on PRs and deploys it to GitHub Pages on main. - Stories and .storybook are excluded from the published tsc build, so the SDK bundle and size budget are unchanged. Live Storybook: https://miracle656.github.io/veil/ (after Pages is enabled). Closes Miracle656#357
|
@Ipramking is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Ipramking Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #357 — Storybook for SDK components: a Storybook for the React components in
sdk/react/, deployed to GitHub Pages.sdk/react/previously exported only hooks + a provider (no visual components), so this adds presentational components for each hook and stories for them.What changed
sdk/react/src/components/— five presentational components, exported frominvisible-wallet-sdk/react. Each pairs with a hook (its JSDoc shows the exact wiring):AccountBadgeuseAccountBalanceCarduseBalanceSendPaymentFormuseSendPaymentTxStatusPilluseTransactionStatusConnectButtonVeilProviderwalletsdk/react/.storybook/,@storybook/react-vite) with a*.stories.tsxper component covering default / loading / error / empty states..github/workflows/storybook.yml— builds Storybook on PRs and deploys it to GitHub Pages onmain(base: './'for the Pages subpath).sdk/package.jsongetsstorybook/build-storybookscripts + devDeps (lockfile updated);sdk/tsconfig.jsonexcludes stories +.storybookso the publishedtscbuild and size budget are unchanged.Acceptance criteria
sdk/react/README.md: https://miracle656.github.io/veil/Verification
npx tsc --noEmit(SDK) — clean (components compile; stories excluded).npm run build-storybook— succeeds (Vite build, all stories compiled, static output inreact/storybook-static).Closes #357