Skip to content

[v0.13.0-beta1-m.1] Bump github.com/containerd/containerd to v1.7.33#11

Merged
corhere merged 2 commits into
Mirantis:v0.13.0-beta1-m.1from
smerkviladze:mcr25-containerd-1.7.33
Jul 10, 2026
Merged

[v0.13.0-beta1-m.1] Bump github.com/containerd/containerd to v1.7.33#11
corhere merged 2 commits into
Mirantis:v0.13.0-beta1-m.1from
smerkviladze:mcr25-containerd-1.7.33

Conversation

@smerkviladze

@smerkviladze smerkviladze commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Bumps containerd to v1.7.33 for the MCR 25 CVE work, together with the transitive upgrades it forces (otel v1.14.0 -> v1.21.0, grpc v1.53.0 -> v1.59.0, protobuf v1.35.2, golang.org/x/*). Without this change, buildx fails to compile against containerd >= v1.7.28.

Two kinds of source adaptations were needed:

  • Compile fix: containerd v1.7.28 renamed ExpiresIn -> ExpiresInSeconds (same type and JSON tag) in the remotes/docker/auth token responses; adapted session/auth/authprovider and util/resolver/authorizer. The ExpiresIn field of buildkit's own session/auth protobuf is a different type and is unchanged.

  • Lint fixes (staticcheck SA1019): the bump deprecates several APIs; adapted to the replacements where they are drop-in:

    • extracted github.com/containerd/platforms and github.com/moby/sys/userns modules (import swaps)
    • trace.NewNoopTracerProvider -> noop.NewTracerProvider
    • reference.SplitObject -> reference.Spec.Digest (equivalent behavior)
    • runtime/v2/runc/options -> api/types/runc/options import path
    • the deprecated otelgrpc interceptors are suppressed with //nolint:staticcheck; migrating to the stats.Handler replacement API is too invasive for this branch.

Also regenerates util/stack/stack.pb.go (protoc-gen-go v1.35.2) to satisfy validate-generated-files.

Verified end-to-end from buildx with a local replace: build, lint, and the integration test subset.

containerd v1.7.28 renamed the ExpiresIn field of the token responses
in remotes/docker/auth to ExpiresInSeconds (same type and JSON tag);
adapt authprovider and resolver/authorizer accordingly. The ExpiresIn
uses of buildkit's own session/auth protobuf type are unchanged.

The bump also upgrades transitive dependencies, notably:
- go.opentelemetry.io/otel v1.14.0 -> v1.21.0 (otelgrpc v0.46.1)
- google.golang.org/grpc v1.53.0 -> v1.59.0
- google.golang.org/protobuf v1.30.0 -> v1.35.2
- golang.org/x/crypto v0.14.0 -> v0.45.0 and other golang.org/x bumps

Adapt to APIs deprecated by the bump (staticcheck SA1019):
- switch to the extracted github.com/containerd/platforms and
  github.com/moby/sys/userns modules
- trace.NewNoopTracerProvider -> noop.NewTracerProvider
- reference.SplitObject -> reference.Spec.Digest (equivalent behavior)
- runtime/v2/runc/options -> api/types/runc/options import path
- suppress SA1019 for the deprecated otelgrpc interceptors; migrating
  to the stats.Handler replacement API is too invasive for this branch

Signed-off-by: Sopho Merkviladze <smerkviladze@mirantis.com>
Regenerate util/stack/stack.pb.go with protoc-gen-go v1.35.2, following
the google.golang.org/protobuf bump.

Signed-off-by: Sopho Merkviladze <smerkviladze@mirantis.com>
@smerkviladze smerkviladze marked this pull request as ready for review July 10, 2026 16:38
@smerkviladze smerkviladze requested review from corhere and dperny July 10, 2026 16:42
@corhere corhere merged commit 1085b95 into Mirantis:v0.13.0-beta1-m.1 Jul 10, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants