[v0.13.0-beta1-m.1] detect: sever semconv relationship to otel sdk#9
Merged
smerkviladze merged 1 commit intoJul 9, 2026
Conversation
Copies over the telemetry sdk detection to utilize our own version of semconv rather than mix the versions between different packages. This will keep a consistent schema url instead of constantly chasing whichever one the otel sdk is using. The only thing left from the otel sdk is `WithFromEnv` which is schemaless and won't conflict for that reason so we can continue to use it. Backport adjustments for v0.13.0-beta1-m.x: - use otel.Version() instead of sdk.Version(): the otel sdk root package does not exist at the otel version pinned by this branch, and its builtin telemetrySDK detector reports otel.Version() too - introduce the exported Resource variable (not previously present on this branch) so importing programs can override the detected resource with one matching their own semconv schema version Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com> (cherry picked from commit 9863dd3) Signed-off-by: Cory Snider <csnider@mirantis.com> (cherry picked from commit 9cbf3ac) Signed-off-by: Sopho Merkviladze <smerkviladze@mirantis.com>
corhere
approved these changes
Jul 9, 2026
smerkviladze
merged commit 29a3d33
into
Mirantis:v0.13.0-beta1-m.1
44 of 46 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from commit 9863dd3 (9cbf3ac)
Mirantis/buildx#10 bumps
google.golang.org/grpcto v1.80.0, which forces the OpenTelemetry SDK from v1.14.0 up to v1.43.0. buildkit'sutil/tracing/detectbuilds its trace resource by mergingresource.Default()(schema URL follows the otel SDK version, now 1.40.0) with its own attributes pinned to semconv v1.17.0. resource.Merge refuses conflicting schema URLs, so any program vendoring this buildkit with a newer otel SDK fails as soon as an exporter is configured:Backport adjustments:
otel.Version()instead ofsdk.Version()(the otel sdk root package does not exist at v1.14.0)detect.Resourcevariable, which is the override hook programs like docker/compose useVerification:
Reproduced the schema-URL error with buildx (Mirantis/buildx#10) built against buildkit
v0.13.0-beta1-m.1, then confirmed it is gone with the replace directive pointed at this branch.